Pool: Replace opensearch with database fuzzysearch on Business Partne… #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SujitMBRDI
requested review from
alexsilva-CGI,
martinfkaeser,
nicoprow and
rainer-exxcellent
and removed request for
alexsilva-CGI
nicoprow
requested changes
Oct 18, 2023
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/repository/LegalEntityRepository.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/repository/LegalEntityRepository.kt
Outdated
Show resolved
Hide resolved
...-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/BusinessPartnerSearchService.kt
Outdated
Show resolved
Hide resolved
...-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/BusinessPartnerSearchService.kt
Outdated
Show resolved
Hide resolved
SujitMBRDI
force-pushed
the
feat/database-fuzzy-search
branch
2 times, most recently
from
a156145 to
b7c6474
Compare
nicoprow
requested changes
Oct 19, 2023
...-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/BusinessPartnerSearchService.kt
Outdated
Show resolved
Hide resolved
...-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/BusinessPartnerSearchService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/repository/LegalEntityRepository.kt
Outdated
Show resolved
Hide resolved
SujitMBRDI
force-pushed
the
feat/database-fuzzy-search
branch
from
812985f to
6920d91
Compare
nicoprow
approved these changes
Oct 19, 2023
nicoprow
requested changes
Oct 19, 2023
...-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/repository/LogisticAddressRepository.kt
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/repository/LegalEntityRepository.kt
Outdated
Show resolved
Hide resolved
SujitMBRDI
force-pushed
the
feat/database-fuzzy-search
branch
from
b0ad334 to
3fe2ad9
Compare
nicoprow
approved these changes
Oct 20, 2023
nicoprow
approved these changes
Oct 23, 2023
nicoprow
force-pushed
the
feat/database-fuzzy-search
branch
from
3fe2ad9 to
125c5ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Till now, we are using opensearch for fetching business partner to type legal enities, address and sites with Name attribute. With this pull request we are replacing opensearch logic with database fuzzysearch.
Fixes #520