-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement Cleaning Logic on Reserve Task #516
Feat: Implement Cleaning Logic on Reserve Task #516
Conversation
...dummy/src/test/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummyTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic diagram can be seen on this #433 (comment)
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/ResponseMappings.kt
Outdated
Show resolved
Hide resolved
4270e8e
to
e6a1b35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Logic for cleaning seems also good.
...dummy/src/test/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummyTest.kt
Show resolved
Hide resolved
bpdm-cleaning-service-dummy/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...ice-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/GenericBusinessPartnerMappings.kt
Outdated
Show resolved
Hide resolved
If the Pool validates a BP (#518) as discussed today, the logic when to create an address needs to be changed. Did I get that right? @nicoprow @rainer-exxcellent @fabiodmota |
e6a1b35
to
7e65600
Compare
So based on that description i changed the code on bpdm-cleaning-service-dummy/src/main/kotlin/org/eclipse/tractusx/bpdm/cleaning/service/CleaningServiceDummy.kt the addres will only be passed based on the address type
is this the correct logic ? |
159be5a
to
bb57726
Compare
bb57726
to
96bc9a7
Compare
Description
Request new cleaning tasks for step "GenericCleaning" from Orchestrator
Create Legal Entity, Site and Address representations from the given generic business partner data
Create BPN request identifiers where missing
Post dummy cleaning results to Orchestrator for step "GenericCleaning"
Create configurable scheduling for performing these on regular time interval
#433
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: