Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (Gate) - Added Parent references for Generic related to LSA Type and Changelog Type rework #500

Merged

Conversation

alexsilva-CGI
Copy link
Contributor

Added Parent references for Generic related to LSA Type and Changelog Type rework

Description

New fields we're added in the Generic Business Partner (ParentID and ParentType) in order to be backwards compatible with the BPDM Gate's L/S/A endpoints. Logic for relationship verification in Sites and Addresses was added.
Changelogs creation was altered, and now businessPartnerType is optional. Mapping of Address Type to Business Partner Type was done as well.

New service for Generic Output persistence was created.

Related issues #490 and #489

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@alexsilva-CGI alexsilva-CGI force-pushed the feat/changelog-and-parent-generic branch from 19ce0f9 to cecd534 Compare September 28, 2023 14:05
@alexsilva-CGI alexsilva-CGI marked this pull request as ready for review September 29, 2023 08:34
@nicoprow nicoprow self-requested a review September 29, 2023 10:25
@alexsilva-CGI alexsilva-CGI force-pushed the feat/changelog-and-parent-generic branch from c9f060a to 1f94a11 Compare September 29, 2023 14:09
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please squash the commits to have a cleaner history.

Then its good to merge from my opinion

…, Optional Changelog BusinessType and Address Type mapping for Business Partner Type. Added Output Service to be used by LSA endpoints.
@alexsilva-CGI alexsilva-CGI force-pushed the feat/changelog-and-parent-generic branch from 1f94a11 to c5f8bd8 Compare September 29, 2023 14:54
@nicoprow nicoprow merged commit 2b138bb into eclipse-tractusx:main Sep 29, 2023
@nicoprow nicoprow deleted the feat/changelog-and-parent-generic branch September 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants