Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify Gate/Pool API clients #483

Merged

Conversation

martinfkaeser
Copy link
Contributor

Directly expose lazy properties, not functions, for the different APIs.
This is more straight-forward in Kotlin and simplifies the API client implementations.

Copy link
Contributor

@rainer-exxcellent rainer-exxcellent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think the httpServiceProxyFactory should be better documented.

@nicoprow nicoprow merged commit 0138fd5 into eclipse-tractusx:main Sep 22, 2023
@nicoprow nicoprow deleted the refactor/simplify_api_clients branch September 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants