Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use interfaces for Generic Business Partner #481

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

martinfkaeser
Copy link
Contributor

Use interfaces for the Generic Business Partner and its Postal Address.
Move them and dependent base classes to bpdm-common module.

Relates to #476 and #425

Copy link
Contributor

@rainer-exxcellent rainer-exxcellent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks good

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some consideration about the externalId field of the business partner base class in the common. See comment

@martinfkaeser
Copy link
Contributor Author

Added IBaseStreetDto and IStreetDetailedDto to bpdm-common for better reusability.

@nicoprow nicoprow merged commit eab747b into eclipse-tractusx:main Sep 22, 2023
@nicoprow nicoprow deleted the feat/gbpm_interfaces branch September 22, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants