Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add diagrams for pool components #473

Merged

Conversation

fabiodmota
Copy link
Contributor

Description

Create mermaid sequence diagrams showing the different services/components of the BPDM Pool and how they interact each other on these use cases:

  • Create legal entity
  • Update legal entity
  • Search legal entity

#472

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are great diagrams, very detailed and explain a lot about the inner workings of the Pool. I have a small concern with this: The method names in the sequence diagrams could be replaced with a more abstract description. Since there are explanations in the below this is just a minor issue. Also, concepts change less often than method names and it would be a nightmare to keep this documentation up-to-date with the current names and method invocations in detail.

In general I think it's an excellent contribution, not sure though if we should have the aspiration to keep this documention the code (with names and so many details) up-to-date.

I would like to see @gerlitmcoding input on this. From my end, I would approve.

@gerlitmcoding
Copy link
Contributor

I think these are great diagrams, very detailed and explain a lot about the inner workings of the Pool. I have a small concern with this: The method names in the sequence diagrams could be replaced with a more abstract description. Since there are explanations in the below this is just a minor issue. Also, concepts change less often than method names and it would be a nightmare to keep this documentation up-to-date with the current names and method invocations in detail.

In general I think it's an excellent contribution, not sure though if we should have the aspiration to keep this documention the code (with names and so many details) up-to-date.

I would like to see @gerlitmcoding input on this. From my end, I would approve.

As discussed one by one with @nicoprow it is good as you did it @fabiodmota. We will not update every change that comes with every pull request. We will check for each new "release/arc42" if the information are still up-to-date.

@nicoprow nicoprow changed the title docs(Pool): Add diagrams for pool components Docs: Add diagrams for pool components Sep 22, 2023
@nicoprow nicoprow merged commit 69f08ea into eclipse-tractusx:main Sep 22, 2023
@nicoprow nicoprow deleted the docs/add_pool_component_diagrams branch September 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants