Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add cleaning service helm chart #468

Conversation

fabiodmota
Copy link
Contributor

Description

We added a new helm chart to the existing structure to be able to deploy the new cleaning service module.

issue: #453

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@fabiodmota fabiodmota force-pushed the feat/add_cleaning_service_helm_chart branch 4 times, most recently from b75d5bc to 6d91126 Compare September 15, 2023 16:09
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some refactorings to the BPDM application in the commit. Please remove them and add them in a separate pull request as we would like to keep App and Chart contributions separate.

Introducing a new subchart is a change in the original chart. Therefore, you would need to increase the BPDM Chart alpha version for this. (Linting fails for this reason)

@fabiodmota fabiodmota force-pushed the feat/add_cleaning_service_helm_chart branch 6 times, most recently from 8b3ebf4 to 9eda31a Compare September 19, 2023 09:47
@fabiodmota fabiodmota force-pushed the feat/add_cleaning_service_helm_chart branch from af97643 to 8e7911d Compare September 19, 2023 10:48
@fabiodmota fabiodmota changed the title Feat/add cleaning service helm chart Feat(Cleaning): Add cleaning service helm chart Sep 20, 2023
@fabiodmota
Copy link
Contributor Author

The Pull Request was changed based solely on the helm structure for the new cleaning service.
Something detected that caused the workflow to fail was the fact that so many applications, when doing the helm lint test, failed with deployment problems due to resources, without the error being specified.
The resource allocation for simple apps that don't yet have logic was reduced, and the problem was solved

@nicoprow nicoprow changed the title Feat(Cleaning): Add cleaning service helm chart Feat: Add cleaning service helm chart Sep 20, 2023
@nicoprow nicoprow merged commit 4a84a52 into eclipse-tractusx:main Sep 20, 2023
7 checks passed
@nicoprow nicoprow deleted the feat/add_cleaning_service_helm_chart branch September 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants