Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Generic business partner entity fields in Gate #460

Merged

Conversation

martinfkaeser
Copy link
Contributor

@martinfkaeser martinfkaeser commented Sep 13, 2023

Changes to entity model (including DB migration):

  • Make BusinessPartner.isOwner mandatory
  • Rename DB fields for BusinessPartner.bpnL/bpnS/bpnA
  • Make PostalAddress.addressType optional

Fixes for #428

@nicoprow nicoprow changed the title fix(generic bp model): Changes to entity model Fix: Generic business partner entity fields in Gate Sep 14, 2023
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works but I'm not happy with the commit description as its very generic.

I would recommend adding at least the points in the pull request description to the commit description.

- Make BusinessPartner.isOwner mandatory
- Rename DB fields for BusinessPartner.bpnL/bpnS/bpnA
- Make PostalAddress.addressType optional
- DB migration
@martinfkaeser martinfkaeser force-pushed the fix/gbpm_entity_model_changes branch from 0aabb67 to 521c483 Compare September 14, 2023 18:06
@nicoprow nicoprow merged commit b5c1302 into eclipse-tractusx:main Sep 15, 2023
@nicoprow nicoprow deleted the fix/gbpm_entity_model_changes branch September 15, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants