Feat: Setup new Maven Module for CleaningServiceDummy #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need a DOCKER_NOTICE.md like in the other modules? |
| * SPDX-License-Identifier: Apache-2.0 | ||
| ******************************************************************************/ | ||
|
|
||
| package com.catenax.bpdm.cleaning |
There was a problem hiding this comment.
I'm wondering should the package be something below org.eclipse.tractusx.bpdm as it's part of the OpenSource though just a sample? And regarding Maven it's part of the group "org.eclipse.tractusx".
There was a problem hiding this comment.
I changed the package name to org.eclipse.tractusx.bpdm.cleaning
|
Looks good! |
|
LGTM |
nicoprow
requested changes
Sep 14, 2023
nicoprow
changed the title
…p new Maven Module
rainer-exxcellent
force-pushed
the
feat/module-cleaning-service-dummy
branch
from
b44a7a8 to
89b7ba3
Compare
|
I linked the Docker notice into the README file. |
nicoprow
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create maven module for the Cleaning Service Dummy.
I used org.eclipse.tractusx.bpdm.cleaning as base package name because org.eclipse.tractusx.bpdm.cleaning-service-dummy seems a little bit long.
At the moment no persistence to a database is configured.
Solves
#421