-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/rename cdq saas #37
Merged
nicoprow
merged 16 commits into
eclipse-tractusx:main
from
catenax-ng:refactor/rename_cdq_saas
Feb 16, 2023
Merged
Refactor/rename cdq saas #37
nicoprow
merged 16 commits into
eclipse-tractusx:main
from
catenax-ng:refactor/rename_cdq_saas
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes to the charts directories (README and values). Due to our release process we can currently not change the chart and the underlying app in a breaking change at the same time.
- Rename packages and classes
- Rename fields, methods, variables
- Rename application properties etc
- Rename code comments, test method names
- Remove deprecated SaasIdentifierConfigProperties
- Remove CDQ info from application.properties
- Rename test storage, datasource, API key
- Rename api/cdq endpoint
- Rename test comments and data
- Update OpenAPI spec
- Update documentation
- Revert changes to charts for now
- Fix merging error
martinfkaeser
force-pushed
the
refactor/rename_cdq_saas
branch
from
February 16, 2023 09:20
5fe5fe7
to
7d594ef
Compare
- Revert BREAKING API changes for now
- Revert BREAKING API changes for now (OpenAPI spec)
- Revert BREAKING API changes for now (Test config)
nicoprow
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.