Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: API - Rename fields & enums LsaType/ChangelogSubject to BusinessPartnerType #361

Merged
merged 1 commit into from
Aug 3, 2023
Merged

feat: API - Rename fields & enums LsaType/ChangelogSubject to BusinessPartnerType #361

merged 1 commit into from
Aug 3, 2023

Conversation

martinfkaeser
Copy link
Contributor

  • Rename and combine enums LsaType & ChangelogSubject into common BusinessPartnerType
  • Rename field names lsaType & changelogSubject to businessPartnerType including DB field

Fixes #351

@martinfkaeser martinfkaeser force-pushed the feat/API_rename_BusinessPartnerType branch from 6b1e322 to c33864e Compare July 26, 2023 13:59
@martinfkaeser
Copy link
Contributor Author

Please merge only after #359 for DB migrations to be executed in intended sequence!

@martinfkaeser martinfkaeser mentioned this pull request Jul 26, 2023
Merged
nicoprow
nicoprow requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve conflicts and migration file version needs an update due to a previous merge of a pull request.

Otherwise looks good to me

@martinfkaeser martinfkaeser force-pushed the feat/API_rename_BusinessPartnerType branch from c33864e to dfdf7e9 Compare August 1, 2023 06:38
@martinfkaeser martinfkaeser force-pushed the feat/API_rename_BusinessPartnerType branch from dfdf7e9 to 9b35167 Compare August 1, 2023 06:48
@martinfkaeser
Copy link
Contributor Author

Need to resolve conflicts and migration file version needs an update due to a previous merge of a pull request.

Otherwise looks good to me

Done

@martinfkaeser martinfkaeser reopened this Aug 1, 2023
@nicoprow nicoprow merged commit b86b130 into eclipse-tractusx:main Aug 3, 2023
@nicoprow nicoprow deleted the feat/API_rename_BusinessPartnerType branch August 3, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoprow nicoprow nicoprow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Rename LSA-Type -> Business-Partner Type
2 participants
@martinfkaeser @nicoprow