Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API - Rename Type to DeliveryServiceType in AlternativePostalAddressVerboseDto #358

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: API - Rename Type to DeliveryServiceType in AlternativePostalAddressVerboseDto #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bpdm-bridge-dummy/src/main/kotlin/com/catenax/bpdm/bridge/dummy/dto/DtoConversionHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ private fun poolToGateAlternativeAddress(address: AlternativePostalAddressVerbos
baseAddress = baseAddress,
areaPart = areaPart,
deliveryServiceNumber = address.deliveryServiceNumber,
deliveryServiceType = address.type,
deliveryServiceType = address.deliveryServiceType,
deliveryServiceQualifier = address.deliveryServiceQualifier
)
}
2 changes: 1 addition & 1 deletion ...otlin/org/eclipse/tractusx/bpdm/common/dto/response/AlternativePostalAddressVerboseDto.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ data class AlternativePostalAddressVerboseDto(
val deliveryServiceNumber: String = "",

@get:Schema(description = "The type of this specified delivery")
val type: DeliveryServiceType = DeliveryServiceType.PO_BOX,
val deliveryServiceType: DeliveryServiceType = DeliveryServiceType.PO_BOX,

@get:Schema(description = "Delivery Service Qualifier")
val deliveryServiceQualifier: String?,
Expand Down
2 changes: 1 addition & 1 deletion bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/ResponseMappings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ fun AlternativePostalAddress.toDto(): AlternativePostalAddressVerboseDto {
areaPart = AreaDistrictAlternativVerboseDto(
administrativeAreaLevel1 = administrativeAreaLevel1?.let { NameRegioncodeVerboseDto(it.regionName, it.regionCode) },
),
type = deliveryServiceType,
deliveryServiceType = deliveryServiceType,
deliveryServiceNumber = deliveryServiceNumber,
deliveryServiceQualifier = deliveryServiceQualifier
)
Expand Down