fix(gate): fixed the persistence of LegalEntityIdentifier #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
requested changes
Jul 7, 2023
There was a problem hiding this comment.
Logic works for Legal Entities. Needs to have some changes to the migration file before it can be merged. Also the migration file's version number needs to incremented since there has come a new migration file meanwhile. Definitely needs a rebase on main.
Note: This is a solution for legal entity identifiers. There would be another pull request needed for the address identifiers.
bpdm-gate/src/main/resources/db/migration/V4_0_0_5__create_table_legal_entity_identifiers.sql
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/resources/db/migration/V4_0_0_5__create_table_legal_entity_identifiers.sql
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/resources/db/migration/V4_0_0_5__create_table_legal_entity_identifiers.sql
Outdated
Show resolved
Hide resolved
cezaralexandremorais
force-pushed
the
fix/gate_identifiers_not_retrivied
branch
3 times, most recently
from
f252090 to
df8c1dd
Compare
fixed the persistence of the identifiers collection on the legal entity
cezaralexandremorais
force-pushed
the
fix/gate_identifiers_not_retrivied
branch
from
df8c1dd to
c66d326
Compare
nicoprow
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the persistence of the identifiers collection on the legal entity