Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): API-Model: Rename DTOs #268 Step2 #318

Merged

Conversation

rainer-exxcellent
Copy link
Contributor

@rainer-exxcellent rainer-exxcellent commented Jul 4, 2023


(feat): API-Model: Rename DTOs Step2

Description

Currently we have an outdated naming scheme for the API model DTOs: Request, Response and DTO suffix. When those DTOs are used in our model this leads to confusion.
The request and response classes are renamed to the following schema
DTOs that only contain technical keys should be suffixed with Dto,
while DTOs with resolved information should be suffixed with VerboseDto.
_

This Step rename of Gate responses and TypeKeyNameDto

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up to date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files

Additional information

- rename of Gate responses and TypeKeyNameDto
- rename LogisticAddressResponse
@rainer-exxcellent rainer-exxcellent changed the title fix(api): API-Model: Rename DTOs #268 fix(api): API-Model: Rename DTOs #268 Step2 Jul 4, 2023
@rainer-exxcellent rainer-exxcellent marked this pull request as ready for review July 4, 2023 09:26
@nicoprow nicoprow merged commit dd37b1e into eclipse-tractusx:main Jul 7, 2023
@nicoprow nicoprow deleted the feat/api-model_rename_dtos_step2 branch July 7, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants