Gate Persistence: Legal Form should be optional

[SujitMBRDI]

---

title: 'Gate Persistence: Legal Form should be optional'

Description

This pull request makes column 'legal_form_id' from table 'bpdmgate.legal_entities' to accept Null values. And making Legal Form as optional attribute for Legal Entity on Gate Service.

Fixes #272

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up to date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files

[nicoprow]

Looks good so far, just needs a small change in the migration file.

Other than that the commit message format needs to be adapterd. Our commit message format is inspired by angular2 format: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

Scopes in our commit messages are not taken from a list though but can be freely chosen by you.

Regarding this, your commit message would be something like this: "fix(gate): ..."

[nicoprow]

Please remove the schema name here. Without the explicit schema name we would be more flexible in the configuration on where these migration files are applied.

[SujitMBRDI]

Removed schema name

[SujitMBRDI]

Looks good so far, just needs a small change in the migration file.

Other than that the commit message format needs to be adapterd. Our commit message format is inspired by angular2 format: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

Scopes in our commit messages are not taken from a list though but can be freely chosen by you.

Regarding this, your commit message would be something like this: "fix(gate): ..."

Thanks for providing syntax for adding commit message. I have adapted format in recent commit.
Also fixed schema name as suggested.

[nicoprow]

Ok, I thought the failing test execution is a race condition problem but actually the migration versions are duplicated. On the current main there is now already a migration file with version 4_0_0_5, so you would need to increase it. Best is to rebase your branch to main first, then execute the tests again before force pushing

[SujitMBRDI]

Ok, I thought the failing test execution is a race condition problem but actually the migration versions are duplicated. On the current main there is now already a migration file with version 4_0_0_5, so you would need to increase it. Best is to rebase your branch to main first, then execute the tests again before force pushing

Done and ready to merge