fix(gate): Gate persist new fields and fix fields retrieval #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
changed the title
… Added more Street Suffixes and corrected the mapping. Fixed unit tests to account with AdminLvl1 map
alexsilva-CGI
force-pushed
the
fix/gate_persist_new_fields
branch
from
9fde4fe to
ba2b32b
Compare
nicoprow
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Gate persist new fields and fix fields retrieval
Description
This PR adds an table (Roles) to be able to persist the Roles in Legal Entities, Addresses and Sites. Also fixes the administrativeAreaLevel1 mapping, and adds new Street suffixes and prefixes with the correct mapping.
Related issues: fix #280 fix #285
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: