Fix/name parts persist #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
force-pushed
the
fix/name_parts_persist
branch
from
0513cb7 to
9457d49
Compare
nicoprow
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Logic and structure for name parts looks good. But we lose the current names of the business partners. Please migrate the currently existing business partner names so that they appear as the first entry of the name parts array.
Also, please delete the legalName from the LegalEntity as well. The Legal Entity should only have nameparts and the legalShortName.
nicoprow
requested changes
Jun 30, 2023
nicoprow
requested changes
Jun 30, 2023
…s and Sites with the respective mappings
…ty. Migration of Address and Sites names to name_parts
alexsilva-CGI
force-pushed
the
fix/name_parts_persist
branch
from
c9ad31c to
012a40b
Compare
nicoprow
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Persistence of Name Parts
Description
This PR adds an table to be able to persist the Name Parts in Legal Entities, Addresses and Sites. On Sites and Logistic Addresses the name column was also removed. Respective mapping was done also.
Related issues: fix #271
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: