Fix - Removal of unused fields on Pool and Gate Entities and addition of Delivery Service Qualifier #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added deliveryServiceQualifier
alexsilva-CGI
force-pushed
the
fix/persistence_gate_pool_entity_changes
branch
from
5c3fc21 to
3c24d03
Compare
nicoprow
requested changes
Jun 23, 2023
| @@ -105,4 +66,7 @@ class AlternativePostalAddress( | |||
| */ | |||
| @Column(name = "alt_delivery_service_number") | |||
| val deliveryServiceNumber: String = "", | |||
|
|
|||
| @Column(name = "alt_delivery_service_qualifier") | |||
| val deliveryServiceQualifier: String = "", | |||
There was a problem hiding this comment.
Since this is a new column added here, the existing business partners have NULL written in it. Since this entity expects a non null value it leads to an error. In general, if an entity field is not nullable, its column should be not nullable
| @@ -98,4 +65,7 @@ class AlternativePostalAddress( | |||
| */ | |||
| @Column(name = "alt_delivery_service_number") | |||
| val deliveryServiceNumber: String = "", | |||
|
|
|||
| @Column(name = "alt_delivery_service_qualifier") | |||
| val deliveryServiceQualifier: String = "", | |||
There was a problem hiding this comment.
Since this is a new column added here, the existing business partners have NULL written in it. Since this entity expects a non null value it leads to an error. In general, if an entity field is not nullable, its column should be not nullable
nicoprow
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Removal of unused fields on Pool and Gate Entities and addition of Delivery Service Qualifier
Description
This PR removes unused and unnecessary columns in the Entities and Database from the Gate and Pool, and addition of Delivery Service Qualifier on the Alternative Postal Address of both Pool and Gate.
Related issues: fix #284 fix #281 fix #282 fix #283
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: