fix(pool-common):removed remaining saas from pool and common-lib #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changed some mappings on pool to not use SaaS anymore
nicoprow
requested changes
Jun 22, 2023
| @@ -201,7 +147,6 @@ class OpenSearchControllerIT @Autowired constructor( | |||
| val exportResponse = testHelpers.startSyncAndAwaitSuccess(webTestClient, EndpointValues.OPENSEARCH_SYNC_PATH) | |||
|
|
|||
| assertThat(exportResponse.count).isEqualTo(6) | |||
There was a problem hiding this comment.
Why did your remove the assertion whether the exported business partners are searchable? Please reintroduce the assertion and base it on the names of the created legal entities
There was a problem hiding this comment.
i changed this test and split the pull request in another 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed remaining saas from pool and common-lib, and, and changed some mappings on pool to not use SaaS anymore