Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-Model: Update postman collection with new data model #288 #290

Merged

Conversation

SujitMBRDI
Copy link
Contributor

Updated postman collection with new data model for Gate, Pool and Bridge dummy services.

Related to issue : #288

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just needs minor fixes and then ready to merge

Pool:
Update Address: Field "bpn" -> "bpna"
GET Address Partners: Remove unused query parameters

Gate:
POST Sharing State: LSA Type needs to be in uppercase since newest change

@@ -1159,39 +962,44 @@
"value": "{{Pool-Client-ID}}",
"type": "string"
},
{
"key": "accessTokenUrl",
"value": "https://{{Keycloak-Host}}/auth/realms/CX-Central/protocol/openid-connect/token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the protocol since this should be a part of the variable. In some environments its HTTP and in some HTTPS

"key": "clientId",
"value": "{{Gate-Client-ID}}",
"type": "string"
},
{
"key": "accessTokenUrl",
"value": "https://{{Keycloak-Host}}/auth/realms/CX-Central/protocol/openid-connect/token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the protocol since this should be a part of the variable. In some environments its HTTP and in some HTTPS

},
{
"key": "accessTokenUrl",
"value": "https://{{Keycloak-Host}}/auth/realms/CX-Central/protocol/openid-connect/token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the protocol since this should be a part of the variable. In some environments its HTTP and in some HTTPS

]
}
},
"response": []
},
{
"name": "Legal Entity",
"name": "Feild Quality Rules",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@SujitMBRDI
Copy link
Contributor Author

Excellent work! Just needs minor fixes and then ready to merge

Pool: Update Address: Field "bpn" -> "bpna" GET Address Partners: Remove unused query parameters

Gate: POST Sharing State: LSA Type needs to be in uppercase since newest change

@nicoprow, I have made requested changes. Whenever you have the time kindly review and merge them. Cheers!

@nicoprow nicoprow merged commit a0fe03c into eclipse-tractusx:main Jun 23, 2023
@nicoprow nicoprow deleted the feat/update-postman-collection branch June 23, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants