Feat - Fetch of input data from the persistence layer (Logistic Address + Legal Entities) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsilva-CGI
force-pushed
the
feat/persistence_query_input_legalentities
branch
from
07035cb to
11c253e
Compare
nicoprow
requested changes
May 24, 2023
There was a problem hiding this comment.
I can't execute the GET input legal-entities endpoints without error. See comments for improvement suggestions.
Also the tests are not adapted. Currently, the tests for GET input legal-entities still configure the Wiremock for SaaS-Service Mocking. But that is no longer needed when fetching the business partners from the database directly.
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/LegalEntityService.kt
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/LegalEntityService.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/LegalEntityService.kt
Show resolved
Hide resolved
alexsilva-CGI
force-pushed
the
feat/persistence_query_input_legalentities
branch
2 times, most recently
from
ad6c334 to
53ef57e
Compare
cezaralexandremorais
changed the title
alexsilva-CGI
force-pushed
the
feat/persistence_query_input_legalentities
branch
from
0a7873b to
1ff29a6
Compare
… to new service logic
…sponse data class. Removal of unused invalidEntries, Added Mapper to AddressGateInputResponse, removal of unused mapping methods in Address Service, Response Mapping toLogisticAddressDTO according to Datamodel changes
…or persisted data with new JPA pagination
…ted data, fixed logic on update of some entities
… to fetch from database instead, and changed pagination to use JPA Pagination
… removed a call to Saas when getting a single legalentity by externalId
alexsilva-CGI
force-pushed
the
feat/persistence_query_input_legalentities
branch
from
1ff29a6 to
e4d7753
Compare
nicoprow
requested changes
May 30, 2023
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/SiteService.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the fetch of legalentities to call persisted data instead of calling SaaS
Issues related: #153 and #154