Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(meta): add tractusx meta file for repository #128

Merged
merged 1 commit into from
May 10, 2023
Merged

docs(meta): add tractusx meta file for repository #128

merged 1 commit into from
May 10, 2023

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented May 8, 2023

updates #108

@nicoprow nicoprow requested a review from FaGru3n May 8, 2023 12:24
@nicoprow nicoprow changed the title docs(helm): increase alpha version for helm chart files docs(meta): add tractusx meta file for repository May 8, 2023
FaGru3n
FaGru3n approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

please add a little description on your repository meta file

product: "PRODUCT_NAME"
leadingRepository: "LEADING_PRODUCT_REPOSITORY_URL"
repositories:
  - name: "REPOSITORY_1_NAME"
    usage: "DESCRIPTION/PURPOSE"

FaGru3n
FaGru3n suggested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: #128 (review)

@nicoprow nicoprow requested a review from FaGru3n May 10, 2023 07:49
FaGru3n
FaGru3n approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FaGru3n
FaGru3n reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you could add one more empty line at the end...
image

@nicoprow
Copy link
Contributor Author

Added new line at the end of the meta file

@nicoprow nicoprow merged commit 52514eb into main May 10, 2023
@nicoprow nicoprow deleted the docs/meta-file branch May 10, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaGru3n FaGru3n FaGru3n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoprow @FaGru3n