Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpdm): added connection to dependencies in readiness check for bpdm services #1164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SujitMBRDI
Copy link
Contributor

@SujitMBRDI SujitMBRDI commented Dec 16, 2024

Description

This pull request adds dependancy check for services in bpdm as below,

  • Upon startup the Pool is ready when a successful connection to the Orchestrator has been made.
  • Upon startup the Cleaning Service Dummy is ready when a successful connection to the Orchestrator has been made.
  • Upon startup the Gate is ready when a successful connection to the Orchestrator and Pool has been made.
  • Enhanced dependency readiness checks with a scheduler to verify connections to required services every 30 seconds and provided error log if any dependant service is not healthy.

Contributes to #1161

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI added the enhancement New feature or request label Dec 16, 2024
@SujitMBRDI SujitMBRDI added this to the BPDM v6.3.0 / R25.03. milestone Dec 16, 2024
@SujitMBRDI SujitMBRDI requested a review from nicoprow December 16, 2024 13:20
@SujitMBRDI
Copy link
Contributor Author

@nicoprow, I have created draft PR to show my approach for issue 1161. Kindly have a look and provide me your opinion about it.

@SujitMBRDI SujitMBRDI force-pushed the feat/bpdm-connect-dependend branch from e37a5d0 to 8285474 Compare December 19, 2024 05:25
@SujitMBRDI SujitMBRDI marked this pull request as ready for review December 19, 2024 05:31
@SujitMBRDI SujitMBRDI force-pushed the feat/bpdm-connect-dependend branch from 8ed323c to 91ce51d Compare December 19, 2024 12:24
@SujitMBRDI SujitMBRDI force-pushed the feat/bpdm-connect-dependend branch 2 times, most recently from e22981e to 33ac216 Compare January 6, 2025 10:30
…pdm services

feat(bpdm): added connection to dependencies in readiness check for bpdm services

feat(bpdm): added connection to dependencies in readiness check for bpdm services

feat(bpdm): updated realm seeding on umbrella chart with service account

feat(bpdm): disabled real seeding for umbrella chart for bpdm

feat(bpdm): enabled real seeding for umbrella chart for bpdm
@SujitMBRDI SujitMBRDI force-pushed the feat/bpdm-connect-dependend branch from 33ac216 to e437f2d Compare January 7, 2025 07:58
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functonality:

  • BPDM apps failed to start with missing dependency
  • BPDM apps start with existing dependency
  • BPDM apps continue to work when dependency becomes unavailable (also report dependency status)
  • Unauthorized Gate failed to start with with authorized dependencies
  • Authorized BPDM apps start with authorized dependencies

@@ -81,3 +81,19 @@ centralidp:
enabled: true
keycloak:
fullnameOverride: bpdm-centralidp
realmSeeding:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the realm seeding here have a purpose? I don't see how it in fluences the dependency check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants