-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bpdm): added connection to dependencies in readiness check for bpdm services #1164
Open
SujitMBRDI
wants to merge
1
commit into
main
Choose a base branch
from
feat/bpdm-connect-dependend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SujitMBRDI
force-pushed
the
feat/bpdm-connect-dependend
branch
from
December 19, 2024 05:25
e37a5d0
to
8285474
Compare
SujitMBRDI
force-pushed
the
feat/bpdm-connect-dependend
branch
from
December 19, 2024 12:24
8ed323c
to
91ce51d
Compare
SujitMBRDI
force-pushed
the
feat/bpdm-connect-dependend
branch
2 times, most recently
from
January 6, 2025 10:30
e22981e
to
33ac216
Compare
…pdm services feat(bpdm): added connection to dependencies in readiness check for bpdm services feat(bpdm): added connection to dependencies in readiness check for bpdm services feat(bpdm): updated realm seeding on umbrella chart with service account feat(bpdm): disabled real seeding for umbrella chart for bpdm feat(bpdm): enabled real seeding for umbrella chart for bpdm
SujitMBRDI
force-pushed
the
feat/bpdm-connect-dependend
branch
from
January 7, 2025 07:58
33ac216
to
e437f2d
Compare
nicoprow
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the functonality:
- BPDM apps failed to start with missing dependency
- BPDM apps start with existing dependency
- BPDM apps continue to work when dependency becomes unavailable (also report dependency status)
- Unauthorized Gate failed to start with with authorized dependencies
- Authorized BPDM apps start with authorized dependencies
@@ -81,3 +81,19 @@ centralidp: | |||
enabled: true | |||
keycloak: | |||
fullnameOverride: bpdm-centralidp | |||
realmSeeding: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the realm seeding here have a purpose? I don't see how it in fluences the dependency check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds dependancy check for services in bpdm as below,
Contributes to #1161
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: