-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: endpoint to return bpnl/s/a based on the requested identifiers #1146
feat: endpoint to return bpnl/s/a based on the requested identifiers #1146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contribution looks good. Solid logic, tests and documentation provided.
I have some comments regarding the endpoint defintion itself though.
Other than that: Please also add a CHANGELOG.md entry.
Rest looks good to me.
bpdm-pool-api/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/api/PoolBpnApi.kt
Outdated
Show resolved
Hide resolved
bpdm-pool-api/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/api/PoolBpnApi.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces a new endpoint that returns the BPNL/S/A based on the provided request identifiers.
For more information, please refer to #1052.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: