Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: endpoint to return bpnl/s/a based on the requested identifiers #1146

Conversation

dilipdhankecha2530
Copy link
Contributor

Description

This PR introduces a new endpoint that returns the BPNL/S/A based on the provided request identifiers.

For more information, please refer to #1052.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow requested a review from SujitMBRDI December 4, 2024 04:24
@nicoprow nicoprow added the enhancement New feature or request label Dec 4, 2024
@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Dec 4, 2024
@nicoprow nicoprow added the standards-relevant The issue has an impact on the Catena-X standards label Dec 4, 2024
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contribution looks good. Solid logic, tests and documentation provided.

I have some comments regarding the endpoint defintion itself though.

Other than that: Please also add a CHANGELOG.md entry.

Rest looks good to me.

Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoprow nicoprow merged commit 93ac725 into eclipse-tractusx:main Dec 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request standards-relevant The issue has an impact on the Catena-X standards
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants