fix(bpdm-gate): output stage to only provide states based on business partner type #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
reviewed
Oct 29, 2024
| @@ -65,7 +65,7 @@ class BusinessPartnerMappings { | |||
| } } | |||
| .map(::toIdentifierDto) | |||
| }?: emptyList(), | |||
| states = entity.states.map(::toStateDto), | |||
| states = toStateDtos(entity.states, BusinessPartnerType.GENERIC), | |||
There was a problem hiding this comment.
I'm just looking at the identifiers behaviour. Shouldn't the states not better mirror the behaviour of the identifiers and take the states based on the address type?
There was a problem hiding this comment.
In my opinion, yes we can do that and it will be right approach as well.
SujitMBRDI
force-pushed
the
fix/gate-output-states
branch
from
7e809f6 to
2422faf
Compare
…egorized states fix(bpdm-gate): output stage to only provide generic states for uncategorized states fix(bpdm-gate): output stage to only provide states based on business partner type
SujitMBRDI
force-pushed
the
fix/gate-output-states
branch
from
08ae919 to
9a1b556
Compare
SujitMBRDI
changed the title
I have adapted changes as we discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we have fixed logic for gate output stage to retrieve states based on business partner type.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: