Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Pool): Cx Membership Operator Logic #1072

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat(Pool): Cx Membership Operator Logic #1072

merged 1 commit into from
Oct 15, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Oct 14, 2024 •
edited
Loading

Description

feat(Pool): add operator endpoints for searching and updating Cx membership of legal entities

  • add GET and PUT endpoints for new Cx membership REST resource
  • adapt golden record task processing logic to ignore isCatenaXMemberData flag if it is null
  • return isCatenaXMemberData for legal entities as in Pool database for golden record tasks
  • adapt tests
  • adapt documentation

Pre-review checks

Solves #1069

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow marked this pull request as ready for review October 14, 2024 03:46
SujitMBRDI
SujitMBRDI approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nicoprow
feat(Pool): add operator endpoints for searching and updating Cx memb…
9a41a8c 
…ership of legal entities

- add GET and PUT endpoints for new Cx membership REST resource
- adapt golden record task processing logic to ignore isCatenaXMemberData flag if it is null
- return isCatenaXMemberData for legal entities as in Pool database for golden record tasks
- adapt tests
- adapt documentation
@nicoprow nicoprow force-pushed the feat/cx-member-endpoint branch from f8d3430 to 9a41a8c Compare October 15, 2024 05:39
@nicoprow nicoprow merged commit 6a6792d into main Oct 15, 2024
16 checks passed
@nicoprow nicoprow deleted the feat/cx-member-endpoint branch October 15, 2024 05:51
This was referenced Oct 29, 2024
Open
Open
@nicoprow nicoprow added this to the BPDM v6.2.0 / R24.12 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SujitMBRDI SujitMBRDI SujitMBRDI approved these changes

@dilipdhankecha2530 dilipdhankecha2530 Awaiting requested review from dilipdhankecha2530

@maximilianong maximilianong Awaiting requested review from maximilianong

@kunyao-cofinity-x kunyao-cofinity-x Awaiting requested review from kunyao-cofinity-x

@AmirMattarx AmirMattarx Awaiting requested review from AmirMattarx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
BPDM v6.2.0 / R24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoprow @SujitMBRDI