Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cleaning Dummy): Duplication Check #1040

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Aug 23, 2024

Description

Fix duplication check not distinguishing very well between sites and addresses of the same legal entity

  • introduce more precise BPN references to better distinguish between differen business partner names
  • take the uncategorized name parts into account if no categorized business partner name is specified

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow requested a review from SujitMBRDI August 23, 2024 08:15
…etween sites and addresses of the same legal entity

- introduce more precise BPN references to better distinguish between differen business partner names
- take the uncategorized name parts into account if no categorized business partner name is specified
@nicoprow nicoprow force-pushed the fix/cleaning-dummy-duplication-check branch from 46cb888 to 6949265 Compare August 23, 2024 08:30
@nicoprow nicoprow marked this pull request as ready for review August 23, 2024 09:05
@nicoprow nicoprow merged commit 123e4aa into main Aug 26, 2024
17 checks passed
@nicoprow nicoprow deleted the fix/cleaning-dummy-duplication-check branch August 26, 2024 04:16
@nicoprow nicoprow added this to the BPDM v6.2.0 / R24.12 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants