Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Task Resolution): Event Log Based Task Resolution #1039

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Aug 23, 2024

Description

Gates now resolve tasks by using a new Orchestrator finished task event log

  • add a secondary Health Check schedule for gates making sure to still discover missing tasks
  • added finished task event log on Orchestrator
  • added result state search endpoint for healthcheck on Orchestrator
  • changed the gate's resolution logic to use the event log
  • added Orchestrator tests for event log
  • adapted Gate tests accordingly

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow marked this pull request as ready for review August 23, 2024 10:19
@nicoprow nicoprow requested a review from SujitMBRDI August 26, 2024 03:36
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine. looks good to me.

…rator finished task event log

- add a secondary Health Check schedule for gates making sure to still discover missing tasks
- added finished task event log on Orchestrator
- added result state search endpoint for healthcheck on Orchestrator
- changed the gate's resolution logic to use the event log
- added Orchestrator tests for event log
- adapted Gate tests accordingly
@nicoprow nicoprow force-pushed the feat/event-log-based-task-resolution branch from f0367c9 to 33a80ec Compare August 26, 2024 09:22
@nicoprow nicoprow merged commit 9a96fc8 into main Aug 26, 2024
17 checks passed
@nicoprow nicoprow deleted the feat/event-log-based-task-resolution branch August 26, 2024 10:24
@nicoprow nicoprow added this to the BPDM v6.2.0 / R24.12 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants