Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate API: Nameparts #181

Closed
nicoprow opened this issue May 23, 2023 · 1 comment
Closed

Gate API: Nameparts #181

nicoprow opened this issue May 23, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
Catena-X Standard...

Comments

@nicoprow
Copy link
Contributor

Currently legal entities only have one name field in the Gate API. In order to fascilitate the mapping between BPDM and the sharing member systems we should offer to specify the name in parts. Therefore, response and request DTOs should contain an array field "legalNameParts" for legal entities. The short name should still be one field named "legalShortName".
@nicoprow nicoprow added the enhancement New feature or request label May 23, 2023
@nicoprow nicoprow added this to the Catena-X Standard 3.2 milestone May 23, 2023
@nicoprow
Copy link
Contributor Author

Adding nameparts to the legal entity in the gate leads to a big split in the api model between gate and pool. Therefore this issue needs to be refined into smaller steps leading to the introduction of the nameparts array

@nicoprow nicoprow moved this to 📋 Backlog in BPDM Kanban May 25, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue May 30, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
2b912d4 
add legalNameParts to Gate
@nicoprow nicoprow moved this from 📋 Backlog to 🔖 Ready in BPDM Kanban May 30, 2023
@nicoprow nicoprow moved this from 🔖 Ready to 👀 In review in BPDM Kanban May 30, 2023
@nicoprow nicoprow moved this from 👀 In review to 🔖 Ready in BPDM Kanban May 30, 2023
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue May 30, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
75147cf 
add PoolLegalEntityResponse
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue May 30, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
9181109 
fix tests
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue May 31, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
161591c 
remove LegalEntityResponse from pool
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
ed28243 
add legalNameParts to Gate
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
03effc8 
add PoolLegalEntityResponse
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
dca1f47 
fix tests
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
e20714d 
remove LegalEntityResponse from pool
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
f10b623 
fix after merge
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
7f3ad7b 
add PoolLegalEntityResponse
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
afec8ab 
fix tests
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
893bde0 
add PoolLegalEntityResponse
rainer-exxcellent added a commit to catenax-ng/tx-bpdm that referenced this issue Jun 1, 2023
@rainer-exxcellent
feat(api): eclipse-tractusx#181 Gate API: Nameparts
98caad3 
fix tests
@nicoprow nicoprow mentioned this issue Jun 2, 2023
Merged
@nicoprow nicoprow closed this as completed Jun 2, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in BPDM Kanban Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
BPDM Kanban
Archived in project
Milestone
Catena-X Standard 3.2
Development

No branches or pull requests
1 participant
@nicoprow