Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licence headers #113

Closed
FaGru3n opened this issue Apr 27, 2023 · 1 comment
Closed

Licence headers #113

FaGru3n opened this issue Apr 27, 2023 · 1 comment
Assignees
@nicoprow @FaGru3n

Comments

@FaGru3n
Copy link
Contributor

FaGru3n commented Apr 27, 2023

Found some missing header information.
https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-02/#chart-file-structure

Pool:
https://github.com/eclipse-tractusx/bpdm/blob/bpdm-pool-4.3.0/charts/gate/templates/ingress.yaml

Gate:
https://github.com/eclipse-tractusx/bpdm/blob/bpdm-gate-3.3.0/charts/gate/templates/ingress.yaml
@FaGru3n FaGru3n mentioned this issue Apr 27, 2023
Closed
61 tasks
nicoprow added a commit that referenced this issue May 4, 2023
@nicoprow
fix(helm): add license headers to ingress template files
e5427ad 
updates #113
@nicoprow
Copy link
Contributor

nicoprow commented May 4, 2023 •
edited
Loading

Trying to add license header to the ingress file breaks the deployment on argocd. I suspect its because ArgoCD uses helm v2. Here is the issue that should be relevant: helm/helm#4409
Do you have an update or workaround for that?
@FaGru3n ( forgot to mention tag)

@nicoprow nicoprow assigned FaGru3n and unassigned nicoprow May 4, 2023
nicoprow added a commit that referenced this issue May 8, 2023
@nicoprow
fix(helm): add license headers to ingress template files
8e273fb 
updates #113
nicoprow added a commit that referenced this issue May 8, 2023
@nicoprow
fix(helm): add license headers to ingress template files
2e92f69 
updates #113
@nicoprow nicoprow mentioned this issue May 8, 2023
Merged
@nicoprow nicoprow assigned FaGru3n and unassigned FaGru3n May 8, 2023
nicoprow added a commit that referenced this issue May 11, 2023
@nicoprow
fix(helm): add license headers to ingress template files
3336354 
updates #113
nicoprow added a commit that referenced this issue May 11, 2023
@nicoprow
fix(helm): add license headers to ingress template files
efe80b0 
updates #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicoprow nicoprow

@FaGru3n FaGru3n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicoprow @FaGru3n