Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

feat!: Now works with v6 API #1

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

flozf
Copy link
Contributor

@flozf flozf commented May 27, 2024

Description

Updated the API for the V6 API (mainly additional states)

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@flozf flozf marked this pull request as ready for review June 19, 2024 11:58
NOTICE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes need to be adapted for License and docs.
Once that is done, we can create IP issue for this repository.
Please confirm once it is done.

@flozf
Copy link
Contributor Author

flozf commented Jun 24, 2024

Done

@SujitMBRDI
Copy link
Contributor

SujitMBRDI commented Jun 25, 2024

Done

Thanks for adapting changes, But I do have some small recommendations.

.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
DEPENDENCIES.dash Outdated Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
@SujitMBRDI SujitMBRDI self-requested a review June 25, 2024 13:00
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the requested changes have been added to the PR, it is a good starting point for an initial contribution and the IP-Check.

@flozf flozf requested a review from SujitMBRDI June 26, 2024 14:41
@SujitMBRDI
Copy link
Contributor

@flozf,
I have created an IP-Check issue at EF: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15499

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEPENDENCIES file is incomplete.
Did you generate it with the Eclipse Dash License Tool?
The Licenses and EF approvals + IP Lab issue numbers are missing.

In case you need help doing that for Python dependencies, please contact @AngelikaWittek for info

@AngelikaWittek
Copy link

@SujitMBRDI can you please inform us when this PR will be ready to be merged? This repository is planned to be archived before end of July.

@SujitMBRDI
Copy link
Contributor

SujitMBRDI commented Jul 15, 2024

@SujitMBRDI can you please inform us when this PR will be ready to be merged? This repository is planned to be archived before end of July.

@AngelikaWittek, I had discussion with business person. This repo is not going to be use as of now so we are ready to Archive same. I shall merge the PR and will close open issue.

@SujitMBRDI SujitMBRDI merged commit 14a8e56 into eclipse-tractusx:main Jul 15, 2024
2 checks passed
@SujitMBRDI SujitMBRDI removed their assignment Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants