-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes need to be adapted for License and docs.
Once that is done, we can create IP issue for this repository.
Please confirm once it is done.
See issue eclipse-tractusx#2
Done |
Thanks for adapting changes, But I do have some small recommendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the requested changes have been added to the PR, it is a good starting point for an initial contribution and the IP-Check.
@flozf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DEPENDENCIES
file is incomplete.
Did you generate it with the Eclipse Dash License Tool?
The Licenses and EF approvals + IP Lab issue numbers are missing.
In case you need help doing that for Python dependencies, please contact @AngelikaWittek for info
@SujitMBRDI can you please inform us when this PR will be ready to be merged? This repository is planned to be archived before end of July. |
@AngelikaWittek, I had discussion with business person. This repo is not going to be use as of now so we are ready to Archive same. I shall merge the PR and will close open issue. |
Description
Updated the API for the V6 API (mainly additional
state
s)Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: