Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update settings for portal repos #23

Merged
merged 4 commits into from
Aug 17, 2023
Merged

chore: update settings for portal repos #23

merged 4 commits into from
Aug 17, 2023

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Aug 16, 2023

Description

update repository settings for portal-repository:

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

set in the course of eclipse-tractusx/portal-assets@be147b7
default branch !=main is against project internal release guidelines
branch protection rules and delete branch on merge
@evegufy evegufy requested review from a team as code owners August 16, 2023 13:20
@github-actions

This comment has been minimized.

@netomi
Copy link
Contributor

netomi commented Aug 16, 2023

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.

Could a second committer / project-lead approve these changes?

@github-actions
Copy link

Diff for 597e908:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-tractusx[id=eclipse-tractusx]
  there have been 39 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="portal-assets"] {
!     description                                              = null -> "Portal Assets"
!   }

  
!   repository[name="portal-backend"] {
!     default_branch                                           = "dev" -> "main"
!     description                                              = null -> "Portal Backend"
!   }

  
!   repository[name="portal-cd"] {
!     default_branch                                           = "dev" -> "main"
!     description                                              = "portal cd" -> "Portal - Continuous Deployment"
!   }

  
!   repository[name="portal-frontend"] {
!     default_branch                                           = "dev" -> "main"
!     description                                              = null -> "Portal Frontend"
!   }

  
!   repository[name="portal-frontend-registration"] {
!     default_branch                                           = "dev" -> "main"
!     description                                              = null -> "Portal Frontend Registration"
!   }

  
!   repository[name="portal-iam"] {
!     delete_branch_on_merge                                   = false -> true
!     description                                              = "portal iam" -> "IAM - Keycloak instances"
!   }

+   add branch_protection_rule[pattern="main", repository="portal-iam"] {
+     allows_deletions                                         = false
+     allows_force_pushes                                      = false
+     blocks_creations                                         = false
+     bypass_force_push_allowances                             = []
+     bypass_pull_request_allowances                           = []
+     dismisses_stale_reviews                                  = true
+     is_admin_enforced                                        = false
+     lock_allows_fetch_and_merge                              = false
+     lock_branch                                              = false
+     pattern                                                  = "main"
+     push_restrictions                                        = []
+     require_last_push_approval                               = false
+     required_approving_review_count                          = "1"
+     requires_code_owner_reviews                              = false
+     requires_commit_signatures                               = false
+     requires_conversation_resolution                         = false
+     requires_deployments                                     = false
+     requires_linear_history                                  = false
+     requires_pull_request                                    = true
+     requires_status_checks                                   = false
+     restricts_pushes                                         = false
+     restricts_review_dismissals                              = false
+   }

  
!   repository[name="portal-shared-components"] {
!     delete_branch_on_merge                                   = false -> true
!     description                                              = null -> "Portal Shared UI Components"
!   }

+   add branch_protection_rule[pattern="main", repository="portal-shared-components"] {
+     allows_deletions                                         = false
+     allows_force_pushes                                      = false
+     blocks_creations                                         = false
+     bypass_force_push_allowances                             = []
+     bypass_pull_request_allowances                           = []
+     dismisses_stale_reviews                                  = true
+     is_admin_enforced                                        = false
+     lock_allows_fetch_and_merge                              = false
+     lock_branch                                              = false
+     pattern                                                  = "main"
+     push_restrictions                                        = []
+     require_last_push_approval                               = false
+     required_approving_review_count                          = "1"
+     requires_code_owner_reviews                              = false
+     requires_commit_signatures                               = false
+     requires_conversation_resolution                         = false
+     requires_deployments                                     = false
+     requires_linear_history                                  = false
+     requires_pull_request                                    = true
+     requires_status_checks                                   = false
+     restricts_pushes                                         = false
+     restricts_review_dismissals                              = false
+   }
  
  Plan: 2 to add, 13 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-tractusx[id=eclipse-tractusx]
--- original
+++ canonical
@@ -429,13 +429,17 @@
       web_commit_signoff_required: false
     }
     orgs.newRepo('puris-backend') {
+      allow_update_branch: false
       archived: true
       description: "puris-backend"
+      secret_scanning_push_protection: "disabled"
       web_commit_signoff_required: false
     }
     orgs.newRepo('puris-frontend') {
+      allow_update_branch: false
       archived: true
       description: "puris-frontend"
+      secret_scanning_push_protection: "disabled"
       web_commit_signoff_required: false
     }
     orgs.newRepo('sd-factory') {

@evegufy
Copy link
Contributor Author

evegufy commented Aug 16, 2023

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.

Could a second committer / project-lead approve these changes?

@netomi Thank you, I removed the setting for the default branch.

@Siegfriedk Could you please give your approval as project lead?

@evegufy
Copy link
Contributor Author

evegufy commented Aug 17, 2023

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.
Could a second committer / project-lead approve these changes?

@netomi Thank you, I removed the setting for the default branch.

@Siegfriedk Could you please give your approval as project lead?

@SebastianBezold Could you please give your approval? Sigi is on leave I heard.

@SebastianBezold
Copy link
Contributor

Hi,

from my point of view the description and branch protection rules are fine, but I'm not sure, if a PL (@giterrific, @danielmiehle, @Siegfriedk) approval is needed.

@netomi
Copy link
Contributor

netomi commented Aug 17, 2023

Considering the type of changes, another approval from a fellow committer are enough imho. I will merge at as is.

@netomi netomi merged commit 2496dd4 into eclipse-tractusx:main Aug 17, 2023
@netomi
Copy link
Contributor

netomi commented Aug 17, 2023

changes have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants