Unable to add new TextMate theme #190
Comments
|
Yes it's normal, because this feature is not implemented. Any PR are welcome! |
|
Then I would at least let people know. Having a button that doesn't work isn't really helping. |
Maybe we could instead enable the button and put a handler popping up "Send PRs to #190 to enable this feature" :P |
|
I might get around to working on this when I have a moment as I intend to revive https://github.com/eclipse-color-theme/eclipse-color-theme and add support for setting the generic editors colours based on the users JDT syntax colours. Are there any tips someone might have for me? If not it’s okay, I’ll figure it out eventually :) |
|
IMO, if we can install TextMate themes, as there are already many of them, it wouldn't be necessary to have an extra layer such as eclipse-color-themes to deal with syntax highlighting themes. |
|
If I unpack In the positive case: If the version changes due to an update, Eclipse would probably not migrate files edited in there?... |
|
the content of the plugins/ directory are internal and shouldn't be modified directly by users. |
|
Then it may have to be located in |
|
Themes should be added via preferences dialog. Some options could be offered to add CSS, extract CSS to allow editing a copy and so on, but users should simply not have to dig into the IDE installation on filesystem; as there are a lot of ways to make mistakes here. |
|
Can't this plugin provide the same UI for color configuration in Preferences as is done for specific languages? I prefer to have a way to change separate colors for each language element then importing complete themes. |
|
Adding preferences for individual colors is a lot of work, and how profitable it is to the crowd is arguable. As languages can have specific token types, it's also not possible to statically get a list of all possible token, so we cannot hardcode a complete set of preferences anyway. But in any case this current #190 is a preliminary step before we can enable any further configuration. Contributions would be welcome! |
|
I agree that making the buttons work is most important. But as a user I like Eclipse to work as an integrated platform that provides a consistent UI for similar functions. Color settings are already spread over different places and do not always work together well. |
|
Fixed with #253 |
In Eclipse 2018-09 I have a preference page for selecting themes, the page says I can "Create" themes, but the "New…" button is disabled:
Installation Details
The text was updated successfully, but these errors were encountered: