Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts types 2022 08 10 #822

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Aug 11, 2022

Almost any update of the JSON schemas causes problems :-(
see getModelVersion(...) in ThingModelHelpers this time

@danielpeintner
Copy link
Member Author

danielpeintner commented Aug 11, 2022

EDIT: OPCUA Problem solved by running npm dedupe as mentioned in #765 (comment). This is so uncommon to me that I always forget..

I wanted to update package-lock.json and run into some issues with OPCUA.
@erossignon do you have an idea?

I do not really understand why this can happen since all "node-opcua*" dependencies are set to a fixed version.

Error: packages/binding-opcua/src/opcua-protocol-client.ts(113,9): error TS2769: No overload matches this call.
  Overload 1 of 4, '(nodeToBrowse: BrowseDescriptionLike, callback: ResponseCallback<BrowseResult>): void', gave the following error.
    Argument of type '(err: Error | null, browseResult?: BrowseResult) => void' is not assignable to parameter of type 'ResponseCallback<BrowseResult>'.
      Types of parameters 'browseResult' and 'result' are incompatible.
        Type 'import("/home/runner/work/thingweb.node-wot/thingweb.node-wot/node_modules/node-opcua-client/node_modules/node-opcua-types/dist/_generated_opcua_types").BrowseResult' is not assignable to type 'import("/home/runner/work/thingweb.node-wot/thingweb.node-wot/node_modules/node-opcua-types/dist/_generated_opcua_types").BrowseResult'.
          Types of property 'references' are incompatible.

@erossignon
Copy link
Contributor

Let me check

@erossignon
Copy link
Contributor

erossignon commented Aug 11, 2022

regenerating the pakcage-lock.json file by deleting it before running npm install again could help you as well and be a faster alternative to dedupe.

@danielpeintner
Copy link
Member Author

Let me check

OPCUA issues resolved ... missed to run npm dedupe

@danielpeintner
Copy link
Member Author

@relu91
the remaining issues relate to ThingModel creation/validation.

  • "@context": ["http://www.w3.org/ns/td"] is no longer a valid context for TM
  • ...

Do you want to fix them in this PR?
The alternative would be to ignore them for now and fix them in a follow-up PR?

@relu91
Copy link
Member

relu91 commented Sep 15, 2022

Do you want to fix them in this PR?
The alternative would be to ignore them for now and fix them in a follow-up PR?

Did it now, sorry history got messed up and I had to force push.

@danielpeintner
Copy link
Member Author

LGTM

@danielpeintner danielpeintner merged commit 0b25e24 into eclipse-thingweb:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants