Update node-coap & types/readable-stream dependency and recreate package-lock.json #1297

danielpeintner · 2024-07-02T08:46:10Z

danielpeintner · 2024-07-02T08:47:15Z

Note: npm run build still causes issues...

node_modules/@types/readable-stream/index.d.ts:355:9 - error TS2416: Property 'pipe' in type 'Duplex' is not assignable to the same property in base type '_Writable'.
  Type '<S extends _IWritable>(dest: S, pipeOpts?: { end?: boolean | undefined; } | undefined) => S' is not assignable to type '<T extends WritableStream>(destination: T, options?: { end?: boolean | undefined; } | undefined) => T'.
    Types of parameters 'dest' and 'destination' are incompatible.
      Type 'T' is not assignable to type '_IWritable'.
        Type 'WritableStream' is not assignable to type '_IWritable'.
          The types returned by 'end(...)' are incompatible between these types.
            Type 'void' is not assignable to type '_IWritable'.

355         pipe<S extends _IWritable>(dest: S, pipeOpts?: { end?: boolean | undefined }): S;
            ~~~~


Found 1 error.

danielpeintner · 2024-07-02T09:02:15Z

Mhh, the latest package-lock.json file has @types/readable-stream in v4 only.
Still it is not working... 🤷‍♂️

JKRhb · 2024-07-02T13:00:50Z

Looking a bit closer into @types/readable-stream, this seems to actually be an upstream issue with the type definitions themselves. Pretty strange, though, that this error has not occurred before in node-coap, where the types have been updated before 🤔

danielpeintner · 2024-07-02T13:09:32Z

this seems to actually be an upstream issue with the type definitions themselves

Can you point me to what you mean by that?

JKRhb · 2024-07-02T13:19:26Z

this seems to actually be an upstream issue with the type definitions themselves

Can you point me to what you mean by that?

I got the impression that the type definitions themselves are invalid, since VSCode also shows the error for the pipe method within the definition of the Duplex class when navigating to the respective file in the node_modules folder. So maybe this needs to be fixed upstream, in the code of @types/readable-stream itself (and is not related to the handling of the dependency in one of our direct dependencies). Although I am still wondering why this error only occurs here and not in node-coap :/

JKRhb · 2024-07-02T13:45:15Z

Two months ago, these changes here have been made that affect the pipe method in question: DefinitelyTyped/DefinitelyTyped@14677d3

Maybe that is the root of the problem :/

JKRhb · 2024-07-02T13:51:02Z

Okay, so if you change the line

        pipe<S extends _IWritable>(dest: S, pipeOpts?: { end?: boolean | undefined }): S;

in the Duplex class to

        pipe<S extends NodeJS.WritableStream>(dest: S, pipeOpts?: { end?: boolean | undefined }): S;

the transpilation works again :) Maybe this has been an oversight when they made the changes linked above.

JKRhb · 2024-07-02T14:04:46Z

I've opened DefinitelyTyped/DefinitelyTyped#69974 as a potential fix for the issue.

JKRhb · 2024-07-09T19:29:58Z

With DefinitelyTyped/DefinitelyTyped#69974 merged, this hopefully should work now 🤞

JKRhb

With these changes, the build and I think also the tests should now succeed again :)

package.json

package-lock.json

Co-authored-by: Jan Romann <[email protected]>

danielpeintner · 2024-07-10T08:04:42Z

Thank you very much @JKRhb 👍

It works now as expected and we can merge the PR as is I think.
@relu91 ?

EDIT: I re-run the whole process from https://github.com/eclipse-thingweb/node-wot?tab=readme-ov-file#development-internals which recreated the package-lock.json files slightly (see ee30eec) and now the CI pipeline fails 🤷‍♂️
Tests are all "passing" but at the end we get
Error: Process completed with exit code 1.

JKRhb · 2024-07-10T09:38:31Z

Hmm, for me the regeneration of the package-lock.json yields a somewhat different result:

Diff

diff --git a/package-lock.json b/package-lock.json
index 317224a9..0a01a0b1 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1830,53 +1830,6 @@
                 "node": ">= 8"
             }
         },
-        "node_modules/aproba": {
-            "version": "1.2.0",
-            "resolved": "https://registry.npmjs.org/aproba/-/aproba-1.2.0.tgz",
-            "integrity": "sha512-Y9J6ZjXtoYh8RnXVCMOU/ttDmk1aBjunq9vO0ta5x85WDQiQfUF9sIPBITdbiiIVcBo03Hi3jMxigBtsddlXRw==",
-            "optional": true
-        },
-        "node_modules/are-we-there-yet": {
-            "version": "1.1.7",
-            "resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.7.tgz",
-            "integrity": "sha512-nxwy40TuMiUGqMyRHgCSWZ9FM4VAoRP4xUYSTv5ImRog+h9yISPbVH7H8fASCIzYn9wlEv4zvFL7uKDMCFQm3g==",
-            "deprecated": "This package is no longer supported.",
-            "optional": true,
-            "dependencies": {
-                "delegates": "^1.0.0",
-                "readable-stream": "^2.0.6"
-            }
-        },
-        "node_modules/are-we-there-yet/node_modules/isarray": {
-            "version": "1.0.0",
-            "resolved": "https://registry.npmjs.org/isarray/-/isarray-1.0.0.tgz",
-            "integrity": "sha512-VLghIWNM6ELQzo7zwmcg0NmTVyWKYjvIeM83yjp0wRDTmUnrM678fQbcKBo6n2CJEF0szoG//ytg+TKla89ALQ==",
-            "optional": true
-        },
-        "node_modules/are-we-there-yet/node_modules/readable-stream": {
-            "version": "2.3.8",
-            "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.8.tgz",
-            "integrity": "sha512-8p0AUk4XODgIewSi0l8Epjs+EVnWiK7NoDIEGU0HhE7+ZyY8D1IMY7odu5lRrFXGg71L15KG8QrPmum45RTtdA==",
-            "optional": true,
-            "dependencies": {
-                "core-util-is": "~1.0.0",
-                "inherits": "~2.0.3",
-                "isarray": "~1.0.0",
-                "process-nextick-args": "~2.0.0",
-                "safe-buffer": "~5.1.1",
-                "string_decoder": "~1.1.1",
-                "util-deprecate": "~1.0.1"
-            }
-        },
-        "node_modules/are-we-there-yet/node_modules/string_decoder": {
-            "version": "1.1.1",
-            "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.1.1.tgz",
-            "integrity": "sha512-n/ShnvDi6FHbbVfviro+WojiFzv+s8MPMHBczVePfUpDJLwoLT0ht1l4YwBCbi8pJAveEEdnkHyPyTP/mzRfwg==",
-            "optional": true,
-            "dependencies": {
-                "safe-buffer": "~5.1.0"
-            }
-        },
         "node_modules/arg": {
             "version": "4.1.3",
             "resolved": "https://registry.npmjs.org/arg/-/arg-4.1.3.tgz",
@@ -3160,15 +3113,6 @@
                 "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
             }
         },
-        "node_modules/code-point-at": {
-            "version": "1.1.0",
-            "resolved": "https://registry.npmjs.org/code-point-at/-/code-point-at-1.1.0.tgz",
-            "integrity": "sha512-RpAVKQA5T63xEj6/giIbUEtZwJ4UFIc3ZtvEkiaUERylqe8xb5IvqcgOurZLahv93CLKfxcw5YI+DZcUBRyLXA==",
-            "optional": true,
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
         "node_modules/color-convert": {
             "version": "2.0.1",
             "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-2.0.1.tgz",
@@ -3307,12 +3251,6 @@
             "integrity": "sha512-ZMkYO/LkF17QvCPqM0gxw8yUzigAOZOSWSHg91FH6orS7vcEj5dVZTidN2fQ14yBSdg97RqhSNwLUXInd52OTA==",
             "dev": true
         },
-        "node_modules/console-control-strings": {
-            "version": "1.1.0",
-            "resolved": "https://registry.npmjs.org/console-control-strings/-/console-control-strings-1.1.0.tgz",
-            "integrity": "sha512-ty/fTekppD2fIwRvnZAVdeOiGd1c7YXEixbgJTNzqcxJWKQnjJ/V1bNEEE6hygpM3WjwHFUVK6HTjWSzV4a8sQ==",
-            "optional": true
-        },
         "node_modules/constants-browserify": {
             "version": "1.0.0",
             "resolved": "https://registry.npmjs.org/constants-browserify/-/constants-browserify-1.0.0.tgz",
@@ -3574,18 +3512,6 @@
                 "node": ">=0.10"
             }
         },
-        "node_modules/decompress-response": {
-            "version": "4.2.1",
-            "resolved": "https://registry.npmjs.org/decompress-response/-/decompress-response-4.2.1.tgz",
-            "integrity": "sha512-jOSne2qbyE+/r8G1VU+G/82LBs2Fs4LAsTiLSHOCOMZQl2OKZ6i8i4IyHemTe+/yIXOtTcRQMzPcgyhoFlqPkw==",
-            "optional": true,
-            "dependencies": {
-                "mimic-response": "^2.0.0"
-            },
-            "engines": {
-                "node": ">=8"
-            }
-        },
         "node_modules/deep-eql": {
             "version": "4.1.4",
             "resolved": "https://registry.npmjs.org/deep-eql/-/deep-eql-4.1.4.tgz",
@@ -3662,12 +3588,6 @@
                 "node": ">=0.4.0"
             }
         },
-        "node_modules/delegates": {
-            "version": "1.0.0",
-            "resolved": "https://registry.npmjs.org/delegates/-/delegates-1.0.0.tgz",
-            "integrity": "sha512-bd2L678uiWATM6m5Z1VzNCErI3jiGzt6HGY8OVICs40JQq/HALfbyNJmp0UDakEY4pMMaN0Ly5om/B1VI/+xfQ==",
-            "optional": true
-        },
         "node_modules/depd": {
             "version": "2.0.0",
             "resolved": "https://registry.npmjs.org/depd/-/depd-2.0.0.tgz",
@@ -3720,18 +3640,6 @@
                 "npm": "1.2.8000 || >= 1.4.16"
             }
         },
-        "node_modules/detect-libc": {
-            "version": "1.0.3",
-            "resolved": "https://registry.npmjs.org/detect-libc/-/detect-libc-1.0.3.tgz",
-            "integrity": "sha512-pGjwhsmsp4kL2RTz08wcOlGN83otlqHeD/Z5T8GXZB+/YcpQ/dgo+lbU8ZsGxV0HIvqqxo9l7mqYwyYMD9bKDg==",
-            "optional": true,
-            "bin": {
-                "detect-libc": "bin/detect-libc.js"
-            },
-            "engines": {
-                "node": ">=0.10"
-            }
-        },
         "node_modules/detective": {
             "version": "5.2.1",
             "resolved": "https://registry.npmjs.org/detective/-/detective-5.2.1.tgz",
@@ -5302,70 +5210,6 @@
                 "url": "https://github.com/sponsors/ljharb"
             }
         },
-        "node_modules/gauge": {
-            "version": "2.7.4",
-            "resolved": "https://registry.npmjs.org/gauge/-/gauge-2.7.4.tgz",
-            "integrity": "sha512-14x4kjc6lkD3ltw589k0NrPD6cCNTD6CWoVUNpB85+DrtONoZn+Rug6xZU5RvSC4+TZPxA5AnBibQYAvZn41Hg==",
-            "deprecated": "This package is no longer supported.",
-            "optional": true,
-            "dependencies": {
-                "aproba": "^1.0.3",
-                "console-control-strings": "^1.0.0",
-                "has-unicode": "^2.0.0",
-                "object-assign": "^4.1.0",
-                "signal-exit": "^3.0.0",
-                "string-width": "^1.0.1",
-                "strip-ansi": "^3.0.1",
-                "wide-align": "^1.1.0"
-            }
-        },
-        "node_modules/gauge/node_modules/ansi-regex": {
-            "version": "2.1.1",
-            "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz",
-            "integrity": "sha512-TIGnTpdo+E3+pCyAluZvtED5p5wCqLdezCyhPZzKPcxvFplEt4i+W7OONCKgeZFT3+y5NZZfOOS/Bdcanm1MYA==",
-            "optional": true,
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
-        "node_modules/gauge/node_modules/is-fullwidth-code-point": {
-            "version": "1.0.0",
-            "resolved": "https://registry.npmjs.org/is-fullwidth-code-point/-/is-fullwidth-code-point-1.0.0.tgz",
-            "integrity": "sha512-1pqUqRjkhPJ9miNq9SwMfdvi6lBJcd6eFxvfaivQhaH3SgisfiuudvFntdKOmxuee/77l+FPjKrQjWvmPjWrRw==",
-            "optional": true,
-            "dependencies": {
-                "number-is-nan": "^1.0.0"
-            },
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
-        "node_modules/gauge/node_modules/string-width": {
-            "version": "1.0.2",
-            "resolved": "https://registry.npmjs.org/string-width/-/string-width-1.0.2.tgz",
-            "integrity": "sha512-0XsVpQLnVCXHJfyEs8tC0zpTVIr5PKKsQtkT29IwupnPTjtPmQ3xT/4yCREF9hYkV/3M3kzcUTSAZT6a6h81tw==",
-            "optional": true,
-            "dependencies": {
-                "code-point-at": "^1.0.0",
-                "is-fullwidth-code-point": "^1.0.0",
-                "strip-ansi": "^3.0.0"
-            },
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
-        "node_modules/gauge/node_modules/strip-ansi": {
-            "version": "3.0.1",
-            "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz",
-            "integrity": "sha512-VhumSSbBqDTP8p2ZLKj40UjBCV4+v8bUSEpUb4KjRgWk9pbqGF4REFj6KEagidb2f/M6AzC0EmFyDNGaw9OCzg==",
-            "optional": true,
-            "dependencies": {
-                "ansi-regex": "^2.0.0"
-            },
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
         "node_modules/get-assigned-identifiers": {
             "version": "1.2.0",
             "resolved": "https://registry.npmjs.org/get-assigned-identifiers/-/get-assigned-identifiers-1.2.0.tgz",
@@ -5693,12 +5537,6 @@
                 "url": "https://github.com/sponsors/ljharb"
             }
         },
-        "node_modules/has-unicode": {
-            "version": "2.0.1",
-            "resolved": "https://registry.npmjs.org/has-unicode/-/has-unicode-2.0.1.tgz",
-            "integrity": "sha512-8Rf9Y83NBReMnx0gFzA8JImQACstCYWUplepDa9xprwwtmgEZUF0h/i5xSA625zB/I37EtrswSST6OXxwaaIJQ==",
-            "optional": true
-        },
         "node_modules/hash-base": {
             "version": "3.0.4",
             "resolved": "https://registry.npmjs.org/hash-base/-/hash-base-3.0.4.tgz",
@@ -6819,18 +6657,6 @@
                 "node": ">=6"
             }
         },
-        "node_modules/mimic-response": {
-            "version": "2.1.0",
-            "resolved": "https://registry.npmjs.org/mimic-response/-/mimic-response-2.1.0.tgz",
-            "integrity": "sha512-wXqjST+SLt7R009ySCglWBCFpjUygmCIfD790/kVbiGmUgfYGuB14PiTd5DwVxSV4NcYHjzMkoj5LjQZwTQLEA==",
-            "optional": true,
-            "engines": {
-                "node": ">=8"
-            },
-            "funding": {
-                "url": "https://github.com/sponsors/sindresorhus"
-            }
-        },
         "node_modules/minimalistic-assert": {
             "version": "1.0.1",
             "resolved": "https://registry.npmjs.org/minimalistic-assert/-/minimalistic-assert-1.0.1.tgz",
@@ -7296,12 +7122,6 @@
                 "multicast-dns": "cli.js"
             }
         },
-        "node_modules/nan": {
-            "version": "2.14.2",
-            "resolved": "https://registry.npmjs.org/nan/-/nan-2.14.2.tgz",
-            "integrity": "sha512-M2ufzIiINKCuDfBSAUr1vWQ+vuVcA9kqx8JJUsbQi6yf1uGRyb7HfpdfUr5qLXf3B/t8dPvcjhKMmlfnP47EzQ==",
-            "optional": true
-        },
         "node_modules/nanoid": {
             "version": "3.3.1",
             "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.1.tgz",
@@ -7365,39 +7185,6 @@
                 "@sinonjs/commons": "^3.0.0"
             }
         },
-        "node_modules/node-abi": {
-            "version": "2.30.1",
-            "resolved": "https://registry.npmjs.org/node-abi/-/node-abi-2.30.1.tgz",
-            "integrity": "sha512-/2D0wOQPgaUWzVSVgRMx+trKJRC2UG4SUc4oCJoXx9Uxjtp0Vy3/kt7zcbxHF8+Z/pK3UloLWzBISg72brfy1w==",
-            "optional": true,
-            "dependencies": {
-                "semver": "^5.4.1"
-            }
-        },
-        "node_modules/node-abi/node_modules/semver": {
-            "version": "5.7.2",
-            "resolved": "https://registry.npmjs.org/semver/-/semver-5.7.2.tgz",
-            "integrity": "sha512-cBznnQ9KjJqU67B52RMC65CMarK2600WFnbkcaiwWq3xy/5haFJlshgnpjovMVJ+Hff49d8GEn0b87C5pDQ10g==",
-            "optional": true,
-            "bin": {
-                "semver": "bin/semver"
-            }
-        },
-        "node_modules/node-aead-crypto": {
-            "version": "2.2.2",
-            "resolved": "https://registry.npmjs.org/node-aead-crypto/-/node-aead-crypto-2.2.2.tgz",
-            "integrity": "sha512-EtCLL1FmVjj2GlBNcLRn75ea+y6yGuEdoTpqc9zIiRkIKk1ucTsOPoKaHYYxHfMAXWqHu2Dw8a44VSSKz45UTg==",
-            "hasInstallScript": true,
-            "optional": true,
-            "dependencies": {
-                "bindings": "^1.5.0",
-                "nan": "2.14.x",
-                "prebuild-install": "^6.1.3"
-            },
-            "engines": {
-                "node": ">4"
-            }
-        },
         "node_modules/node-coap-client": {
             "version": "1.0.8",
             "resolved": "https://registry.npmjs.org/node-coap-client/-/node-coap-client-1.0.8.tgz",
@@ -8632,19 +8419,6 @@
                 "node": ">=8"
             }
         },
-        "node_modules/npmlog": {
-            "version": "4.1.2",
-            "resolved": "https://registry.npmjs.org/npmlog/-/npmlog-4.1.2.tgz",
-            "integrity": "sha512-2uUqazuKlTaSI/dC8AzicUck7+IrEaOnN/e0jd3Xtt1KcGpwx30v50mL7oPyr/h9bL3E4aZccVwpwP+5W9Vjkg==",
-            "deprecated": "This package is no longer supported.",
-            "optional": true,
-            "dependencies": {
-                "are-we-there-yet": "~1.1.2",
-                "console-control-strings": "~1.1.0",
-                "gauge": "~2.7.3",
-                "set-blocking": "~2.0.0"
-            }
-        },
         "node_modules/number-allocator": {
             "version": "1.0.14",
             "resolved": "https://registry.npmjs.org/number-allocator/-/number-allocator-1.0.14.tgz",
@@ -8654,24 +8428,6 @@
                 "js-sdsl": "4.3.0"
             }
         },
-        "node_modules/number-is-nan": {
-            "version": "1.0.1",
-            "resolved": "https://registry.npmjs.org/number-is-nan/-/number-is-nan-1.0.1.tgz",
-            "integrity": "sha512-4jbtZXNAsfZbAHiiqjLPBiCl16dES1zI4Hpzzxw61Tk+loF+sBDBKx1ICKKKwIqQ7M0mFn1TmkN7euSncWgHiQ==",
-            "optional": true,
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
-        "node_modules/object-assign": {
-            "version": "4.1.1",
-            "resolved": "https://registry.npmjs.org/object-assign/-/object-assign-4.1.1.tgz",
-            "integrity": "sha512-rJgTQnkUnH1sFw8yT6VSU3zD3sWmu6sZhIseY8VX+GRu3P6F7Fu+JNDoXfklElbLJSnc3FUQHVe4cU5hj+BcUg==",
-            "optional": true,
-            "engines": {
-                "node": ">=0.10.0"
-            }
-        },
         "node_modules/object-inspect": {
             "version": "1.13.2",
             "resolved": "https://registry.npmjs.org/object-inspect/-/object-inspect-1.13.2.tgz",
@@ -9152,33 +8908,6 @@
                 "node": ">= 0.4"
             }
         },
-        "node_modules/prebuild-install": {
-            "version": "6.1.4",
-            "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-6.1.4.tgz",
-            "integrity": "sha512-Z4vpywnK1lBg+zdPCVCsKq0xO66eEV9rWo2zrROGGiRS4JtueBOdlB1FnY8lcy7JsUud/Q3ijUxyWN26Ika0vQ==",
-            "optional": true,
-            "dependencies": {
-                "detect-libc": "^1.0.3",
-                "expand-template": "^2.0.3",
-                "github-from-package": "0.0.0",
-                "minimist": "^1.2.3",
-                "mkdirp-classic": "^0.5.3",
-                "napi-build-utils": "^1.0.1",
-                "node-abi": "^2.21.0",
-                "npmlog": "^4.0.1",
-                "pump": "^3.0.0",
-                "rc": "^1.2.7",
-                "simple-get": "^3.0.3",
-                "tar-fs": "^2.0.0",
-                "tunnel-agent": "^0.6.0"
-            },
-            "bin": {
-                "prebuild-install": "bin.js"
-            },
-            "engines": {
-                "node": ">=6"
-            }
-        },
         "node_modules/precond": {
             "version": "0.2.3",
             "resolved": "https://registry.npmjs.org/precond/-/precond-0.2.3.tgz",
@@ -10049,12 +9778,6 @@
                 "ts-expect": "^1.1.0"
             }
         },
-        "node_modules/set-blocking": {
-            "version": "2.0.0",
-            "resolved": "https://registry.npmjs.org/set-blocking/-/set-blocking-2.0.0.tgz",
-            "integrity": "sha512-KiKBS8AnWGEyLzofFfmvKwpdPzqiy16LvQfK3yv/fVH7Bj13/wl3JSR1J+rfgRE9q7xUJK4qvgS8raSOeLUehw==",
-            "optional": true
-        },
         "node_modules/set-function-length": {
             "version": "1.2.2",
             "resolved": "https://registry.npmjs.org/set-function-length/-/set-function-length-1.2.2.tgz",
@@ -10245,17 +9968,6 @@
                 }
             ]
         },
-        "node_modules/simple-get": {
-            "version": "3.1.1",
-            "resolved": "https://registry.npmjs.org/simple-get/-/simple-get-3.1.1.tgz",
-            "integrity": "sha512-CQ5LTKGfCpvE1K0n2us+kuMPbk/q0EKl82s4aheV9oXjFEz6W/Y7oQFVJuU6QG77hRT4Ghb5RURteF5vnWjupA==",
-            "optional": true,
-            "dependencies": {
-                "decompress-response": "^4.2.0",
-                "once": "^1.3.1",
-                "simple-concat": "^1.0.0"
-            }
-        },
         "node_modules/sinon": {
             "version": "11.1.1",
             "resolved": "https://registry.npmjs.org/sinon/-/sinon-11.1.1.tgz",
@@ -11784,15 +11496,6 @@
                 "url": "https://github.com/sponsors/ljharb"
             }
         },
-        "node_modules/wide-align": {
-            "version": "1.1.5",
-            "resolved": "https://registry.npmjs.org/wide-align/-/wide-align-1.1.5.tgz",
-            "integrity": "sha512-eDMORYaPNZ4sQIuuYPDHdQvf4gyCF9rEEV/yPxGfwPkRodwEgiMUUXTx/dex+Me0wxx53S+NgUHaP7y3MGlDmg==",
-            "optional": true,
-            "dependencies": {
-                "string-width": "^1.0.2 || 2 || 3 || 4"
-            }
-        },
         "node_modules/word-wrap": {
             "version": "1.2.5",
             "resolved": "https://registry.npmjs.org/word-wrap/-/word-wrap-1.2.5.tgz",

JKRhb · 2024-07-10T09:54:23Z

Hmm, okay, but even with a different package-lock.json, the tests still fail under Node 18 and Windows. Not sure what is causing the issue here :/

JKRhb · 2024-07-10T10:12:27Z

It seems like this problem is related to Windows in general, as the tests also fail under Node 20 there (see https://github.com/JKRhb/thingweb.node-wot/actions/runs/9872206163/job/27261828401?pr=10). Very strange and annoying :/

danielpeintner · 2024-07-10T12:01:24Z

I agree, it is strange and VERY annoying 😒

JKRhb · 2024-07-10T12:18:37Z

I've created JKRhb#10 to investigate where the issue originates from and so far, it looks like the issue is not related to the latest changes to node-coap and the readable-stream packages. I will go through the bindings one by one to find the one that causes the issue.

danielpeintner · 2024-07-10T12:22:33Z

Note: in #1274 we had issues with Node.js 22 on Windows ... but maybe the problems are similar !?

JKRhb · 2024-07-10T12:24:01Z

Note: in #1274 we had issues with Node.js 22 on Windows ... but maybe the problems are similar !?

Oh, yeah, that actually seems likely now :/ I will include Node 22 on Windows in my investigations as well

relu91 · 2024-07-10T13:13:25Z

Note: in #1274 we had issues with Node.js 22 on Windows ... but maybe the problems are similar !?

There I concluded the the problem was definitely caused in the mbus package, I'm not sure this is the case here.

JKRhb · 2024-07-10T16:40:22Z

Note: in #1274 we had issues with Node.js 22 on Windows ... but maybe the problems are similar !?

There I concluded the the problem was definitely caused in the mbus package, I'm not sure this is the case here.

Thank you! You are right, that seems to actually be the culprit here... I think I got a lot close to the problem by now, but for some reason the test still terminates with a non-zero exit code... Will do some more investigation.

JKRhb · 2024-07-10T17:43:25Z

Hmm, my suggestion for now would skipping the tests for the mbus binding under Windows and investigate the problems separately to be able to move on with the general development.

What is very weird is that the mbus tests seem to succeed, but the exit code is still 1 🤔

JKRhb · 2024-07-10T17:55:25Z

I've now created #1302 as a workaround that would supersede this PR and #1274.

danielpeintner added 2 commits July 2, 2024 10:42

refactor: upgrade node-coap

75cb9e6

refactor: recreate package-lock.json

6e26ef5

danielpeintner requested review from JKRhb and relu91 as code owners July 2, 2024 08:46

danielpeintner mentioned this pull request Jul 2, 2024

Re-creating package-lock.json fails #1292

Closed

danielpeintner added 2 commits July 2, 2024 10:58

refactor: update @types/readable-stream in node-wot

ae8de41

refactor: recreated package-lock.json

0bb181d

danielpeintner changed the title ~~Update node-coap dependency and recreate package-lock.json~~ Update node-coap & types/readable-stream dependency and recreate package-lock.json Jul 2, 2024

JKRhb mentioned this pull request Jul 2, 2024

[readable-stream] fix signature of pipe in Duplex class DefinitelyTyped/DefinitelyTyped#69974

Merged

6 tasks

JKRhb reviewed Jul 9, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package-lock.json Outdated Show resolved Hide resolved

package-lock.json Outdated Show resolved Hide resolved

danielpeintner and others added 4 commits July 10, 2024 09:37

Update package.json

9b32fce

Co-authored-by: Jan Romann <[email protected]>

Update package-lock.json

dc66145

Co-authored-by: Jan Romann <[email protected]>

Update package-lock.json

8cf354c

Co-authored-by: Jan Romann <[email protected]>

refactor: rerun process for re-creating package-lock.json

ee30eec

JKRhb mentioned this pull request Jul 10, 2024

Upgrade dependencies, skip mbus tests under Windows, use Node 22 in CI #1302

Merged

danielpeintner closed this in #1302 Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update node-coap & types/readable-stream dependency and recreate package-lock.json #1297

Update node-coap & types/readable-stream dependency and recreate package-lock.json #1297

danielpeintner commented Jul 2, 2024

danielpeintner commented Jul 2, 2024 •

edited

Loading

danielpeintner commented Jul 2, 2024

JKRhb commented Jul 2, 2024

danielpeintner commented Jul 2, 2024

JKRhb commented Jul 2, 2024

JKRhb commented Jul 2, 2024 •

edited

Loading

JKRhb commented Jul 2, 2024

JKRhb commented Jul 2, 2024

JKRhb commented Jul 9, 2024

JKRhb left a comment •

edited

Loading

danielpeintner commented Jul 10, 2024 •

edited

Loading

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024 •

edited

Loading

JKRhb commented Jul 10, 2024

danielpeintner commented Jul 10, 2024

JKRhb commented Jul 10, 2024

danielpeintner commented Jul 10, 2024

JKRhb commented Jul 10, 2024

relu91 commented Jul 10, 2024

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024

Update node-coap & types/readable-stream dependency and recreate package-lock.json #1297

Update node-coap & types/readable-stream dependency and recreate package-lock.json #1297

Conversation

danielpeintner commented Jul 2, 2024

danielpeintner commented Jul 2, 2024 • edited Loading

danielpeintner commented Jul 2, 2024

JKRhb commented Jul 2, 2024

danielpeintner commented Jul 2, 2024

JKRhb commented Jul 2, 2024

JKRhb commented Jul 2, 2024 • edited Loading

JKRhb commented Jul 2, 2024

JKRhb commented Jul 2, 2024

JKRhb commented Jul 9, 2024

JKRhb left a comment • edited Loading

Choose a reason for hiding this comment

danielpeintner commented Jul 10, 2024 • edited Loading

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024 • edited Loading

JKRhb commented Jul 10, 2024

danielpeintner commented Jul 10, 2024

JKRhb commented Jul 10, 2024

danielpeintner commented Jul 10, 2024

JKRhb commented Jul 10, 2024

relu91 commented Jul 10, 2024

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024

JKRhb commented Jul 10, 2024

danielpeintner commented Jul 2, 2024 •

edited

Loading

JKRhb commented Jul 2, 2024 •

edited

Loading

JKRhb left a comment •

edited

Loading

danielpeintner commented Jul 10, 2024 •

edited

Loading

JKRhb commented Jul 10, 2024 •

edited

Loading