feat(servient): improve handling of client factories #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
client-factories
branch
from
2025919
to
3d863e7
Compare
JKRhb
force-pushed
the
client-factories
branch
from
3d863e7
to
0facb78
Compare
JKRhb
changed the title
ProtocolClientFactories
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 52.49% 52.85% +0.36%
==========================================
Files 69 69
Lines 2185 2189 +4
==========================================
+ Hits 1147 1157 +10
+ Misses 1038 1032 -6 ☔ View full report in Codecov by Sentry. |
JKRhb
changed the title
ProtocolClientFactories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of improvements with regard to the handling of
ProtocolClientFactoriesby introducing a dedicatedclientFactoriesconstructor parameter, adding aremoveClientFactorymethod, improving the documentation, and refactoring some of the examples and test code.