Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: update roadmap publishing.md links #9984

Merged
merged 1 commit into from
Aug 30, 2021
Merged

documentation: update roadmap publishing.md links #9984

merged 1 commit into from
Aug 30, 2021

Conversation

dineshUmasankar
Copy link
Contributor

@dineshUmasankar dineshUmasankar commented Aug 29, 2021

What it does

Fixes: #9974

The roadmap links referenced under publishing.md updated to the proper wiki page:

How to test

This functionality can be tested via manually clicking the updating link or by automatically scanning the documentation for broken links.

Review checklist

Reminder for reviewers

The roadmap links referenced under publishing.md updated to the proper wiki page:

* https://github.com/eclipse-theia/theia/wiki/Eclipse-Theia-Roadmap
@msujew msujew added the documentation issues related to documentation label Aug 30, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dineshUmasankar for taking care of this issue. The new links look good to me 👍

@dineshUmasankar
Copy link
Contributor Author

Thank you for the opportunity. Does this mean issue: #9974 will be closed? I am very new to GitHub, and I would like to contribute more to theia. Should I close this pull request, and make a new pull request if I desire to work on another issue?

@msujew
Copy link
Member

msujew commented Aug 30, 2021

@dineshUmasankar We will merge this pull request (PR) as we see fit. Another Theia member will usually take a look at it and merge it. Often times, a single reviewer is not enough to confidently approve changes. The associated issue will be closed as soon as we merge this PR. Until then, please don't close this PR. You're invited to work on other Theia issues in parallel. There's no limit on the amount of concurrent PRs any single user can create, so feel free to work any issue that you like :)

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 👍

@vince-fugnitto vince-fugnitto merged commit 73c11a1 into eclipse-theia:master Aug 30, 2021
@vince-fugnitto vince-fugnitto added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation: update roadmap publishing.md links
3 participants