Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi root repository : fixed selected repository is not populated. #9954

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

ChayaLau
Copy link
Contributor

@ChayaLau ChayaLau commented Aug 24, 2021

fixed selected repository is not populated for git menu commands when using multi root repository

Signed-off-by: Chaya Lau [email protected]

What it does

populates the selected repository to vscode git commands and preventing the choose a repository window in multi root repository

How to test

  • before testing make sure you are using the vscode git plugin (and not the @Theia\git)
  1. Add at least two git repositories to workspace
  2. select and view the selected repository on the bottom left blue status line.
  3. make a change for one of the files in the selected repository.
  4. navigate to source control panel and click the more button (...) -> click stash submenu -> stash
    before fix : window had show with choose a repository command.
    after fix : the stash skips the choose a repository window and uses the selected repository as the source repo.

Review checklist

Reminder for reviewers

@ChayaLau ChayaLau changed the title fixed selected repository is not populated when using multi root repository multi root repository : fixed selected repository is not populated. Aug 24, 2021
fixed selected repository is not populated for git menu commands when
using multi root repository

Signed-off-by: ChayaLau <[email protected]>
@ChayaLau
Copy link
Contributor Author

@vince-fugnitto , @msujew - can you please approve and merge it before the next release? it is only a minor fix, and i tested to make sure there is no regression when using the theia git. thanks!

@vince-fugnitto vince-fugnitto added git issues related to git multi-root issues related to multi-root support vscode issues related to VSCode compatibility labels Aug 24, 2021
@EstherPerelman
Copy link
Contributor

@colin-grant-work @vince-fugnitto @msujew who can merge it?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the behavior works well when testing with the builtin git plugin:

  • single-root stashing works well
  • multi-root stashing works well - we are no longer prompted to choose the repository, and instead the currently selected one is used

@vince-fugnitto vince-fugnitto merged commit ac38b1d into eclipse-theia:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git multi-root issues related to multi-root support vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants