monaco: adjust find-widget font-family
#9937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the font-family for both the input and result label in the `find-widget` (embedded file-search) in the monaco editor. The change updates the font-family like the rest of the application for consistency (and aligns with vscode) rather than using the default monospaced font. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
monaco
msujew
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Looks good to me 👍
I already addressed this (without mentioning it) in my codicon PR but a dedicated PR makes more sense for this either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the font-family for both the input and result label in the
find-widget(embedded file-search) in the monaco editor. The change updates the font-family like the rest of the application for consistency (and aligns with vscode) rather than using the default monospaced font.before:
after:
How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]