Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend plugin-ext can not load two plugin at the same time #9902

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Fix frontend plugin-ext can not load two plugin at the same time #9902

merged 1 commit into from
Aug 20, 2021

Conversation

misakajimmy
Copy link
Contributor

@misakajimmy misakajimmy commented Aug 13, 2021 •
edited by vince-fugnitto
Loading

What it does

Fixes #9901.
Fix frontend plugin-ext can not load two plugin at the same time

How to test

  1. Use yo generate two frontend hello-world example plugin in the same dir
  2. Start theia with --plugins=local-dir:path/to/dir
  3. check terminal whether it start two plugin

Review checklist

Reminder for reviewers

@misakajimmy
Fix frontend plugin-ext
a4f9c0f 
can not load two frontend plugin at the same time
@vince-fugnitto vince-fugnitto added the plug-in system issues related to the plug-in system label Aug 13, 2021
@tsmaeder tsmaeder self-requested a review August 20, 2021 11:48
tsmaeder
tsmaeder approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm and tested.

@tsmaeder tsmaeder merged commit 8492480 into eclipse-theia:master Aug 20, 2021
@tsmaeder
Copy link
Contributor

@misakajimmy I've taken the liberty to change the commit message.

dna2github pushed a commit to dna2fork/theia that referenced this pull request Aug 25, 2021
@misakajimmy @dna2github
Use correct host id for front-end plugins (eclipse-theia#9902)
1a92ad4
federicobozzini pushed a commit to ARMmbed/theia that referenced this pull request Aug 24, 2022
@misakajimmy @federicobozzini
Use correct host id for front-end plugins (eclipse-theia#9902)
8cebb9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin-ext only can use one plugin at the same time
3 participants
@misakajimmy @tsmaeder @vince-fugnitto