-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preferences: make schemas extensible #9883
Conversation
examples/api-samples/src/browser/api-samples-frontend-module.ts
Outdated
Show resolved
Hide resolved
c5a7d71
to
5a585e6
Compare
b8a90b6
to
77ec9fb
Compare
@paul-marechal @colin-grant-work I refactored and simplified the pull-request to use |
7636170
to
8ca1b62
Compare
@vince-fugnitto thanks for resurrecting this issue about overriding preferences. We've have been using a patched version of Theia for quite some time now so that we can overwrite preferences. This is a good and simple way of allowing extenders to override preferences and would support a lot of our use cases. My main concerns are:
If you prefer this approach to the approach in #8626 that is fine but I will then need to amend that PR so that we can make our changes to preferences in plugins. |
@westbury thank you for the discussion, in the end I believe the change would be something like the two pull-requests combined (easier to rebind, possibility to hide).
Correct, the pull-request aims at making the rebinding of individual
I believe references to preferences should be fine, the
The possibility to |
ba4fbf7
to
3a65ac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring is minimal and seems to make sense.
@westbury is correct that his PR has this feature which this PR does not - keeping a preference alive for programmatic manipulation but (somewhat) hidden from users - but I don't think that's an argument against this PR. That is a separate feature that can be implemented on top of this PR. |
3a65ac3
to
8ee7874
Compare
I dropped the test commit (which performs the rebind for test-purposes). I'll merge once CI is green 👍 |
The commit refactors the binding of preference schemas so they can be easily rebinding by downstream extenders and applications if necessary. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
8ee7874
to
d648472
Compare
What it does
The pull-request allows adopters the ability to more easily rebind preference schemas.
This allows extenders to easily modify preference schemas as illustrated in the commit c5a7d71.
How to test
workspace.preserveWindow
, the preference definition should not be listed as it was removed in c5a7d71 for test purposes.Review checklist
Reminder for reviewers