preferences: add json commands
#9832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds the following commands: - `open user preferences (json)` - `open workspace preferences (json)` - `open folder preferences (json)` The folder command will prompt users to first select a root before opening. Signed-off-by: vince-fugnitto <[email protected]>
msujew
reviewed
Aug 4, 2021
Comment on lines
+150
to
+154
| export const OPEN_FOLDER_PREFERENCES_JSON: Command = { | ||
| id: 'workbench.action.openFolderSettingsFile', | ||
| category: 'Preferences', | ||
| label: 'Open Folder Preferences (JSON)', | ||
| }; |
There was a problem hiding this comment.
As far as I can see there's no normal Open Folder Preferences command in Theia right now. Perhaps it is out of scope for this PR, but do you mind adding it? The appropriate frontend UI in the preferences view is already supported for that:
colin-grant-work
approved these changes
Aug 4, 2021
|
@msujew I'll merge and @colin-grant-work mentioned a follow-up pull-request to add the missing command (out of scope for this pull-request) with some possible additional refactorings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds the following commands:
open user preferences (json)open workspace preferences (json)open folder preferences (json)The folder command will prompt users to first select a root before opening.
How to test
open user preferences (json)- the usersettings.jsonshould be opened in an editor.open workspace preferences (json)- the workspacesettings.jsonshould be opened in an editor.open folder preferences (json)- the respectivesettings.jsonshould be opened after selecting a root.open folder preferences (json)does not appear in a single-root workspace or a multi-root workspace without any root folders.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]