Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: include migration guide #9817

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request introduces a migration guide to the framework to help downstream extensions and applications migrate to newer versions of the framework.

How to test

  • verify documentation content.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Aug 2, 2021
@vince-fugnitto vince-fugnitto self-assigned this Aug 2, 2021
@vince-fugnitto
Copy link
Member Author

I'll leave the pull-request as a draft to see if anyone has any feedback over the content, or format of the initial migration guide of the framework.

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! As we discussed in the community call, the migration guide is supposed to be a living document initiated by the feature author and improved as adopters migrate to new releases.

@vince-fugnitto vince-fugnitto marked this pull request as ready for review August 3, 2021 12:57
@vince-fugnitto
Copy link
Member Author

@paul-marechal should we add some entry about what you discovered, mainly how you can opt to not use the pre-built binaries for keytar and instead build it for your operating system if you run into issues?

@vince-fugnitto vince-fugnitto force-pushed the vf/migration-guide branch 4 times, most recently from 6db47ac to c3d02a3 Compare August 3, 2021 14:11
@vince-fugnitto
Copy link
Member Author

@marcdumais-work I think the initial version of the document is good, it should be updated when adopters notice additional migration steps that might be required after releases 👍

vince-fugnitto and others added 2 commits August 3, 2021 13:38
The commit introduces a `migration guide` to the framework to help
downstream extensions and applications migrate to newer versions of the
framework.

Signed-off-by: vince-fugnitto <[email protected]>
Co-authored-by: Paul Maréchal <[email protected]>
The commit updates the prerequisites documentation to include an update
for `keytar` on `alpine linux`.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

@azatsarynnyy I updated the migration and the prerequisites to include an alpine entry for keytar.

@azatsarynnyy
Copy link
Member

@azatsarynnyy I updated the migration and the prerequisites to include an alpine entry for keytar.

Thank you @vince-fugnitto!

@vince-fugnitto vince-fugnitto merged commit 817a85c into master Aug 4, 2021
@vince-fugnitto vince-fugnitto deleted the vf/migration-guide branch August 4, 2021 16:36
@github-actions github-actions bot added this to the 1.17.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants