terminal: add mouse support of GUI terminal application , such as vim, mc #9805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@linhanyu thank you for your first contribution 👍
Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship so we can accept the changes (it is the reason for the failed CI check).
|
oh, I'm not sure what to do? |
… mouse mode and mc Application such as vim use binary message to indicate mouse event but not utf-8 data. In xterm.js, it be emitted by onBinary. Simplely connect it to send Data and resolved. Test environment: MacOS Signed-off-by: 翰宇 林<[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
msujew
approved these changes
Aug 2, 2021
Signed-off-by: 翰宇 林<[email protected]>
|
Won't be able to make it for 1.17.0, but I'll see to review this PR for 1.18.0. |
paul-marechal
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
vim use binary message to indicate mouse event but not utf-8 data. In xterm.js, it be emitted by onBinary. Simplely connect it to send Data and resolved. Test environment: MacOS
How to test
Open terminal in macos, open vim and type :set mouse=a.
Then Type some word and use mouse to click, normally, cursor would move for.
Review checklist
Reminder for reviewers