fix(scm): add onDidChangeCommitTemplate event #9792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zwingz [email protected]
What it does
add
onDidChangeCommitTemplate
event toSCM
extensions, close #9778In
vscode-git
, when our repo has some change, It will get the inputTemplate and set it to SCM input (updateModalState)and it will call getInputTemplate and getMergeMessage
The SCM will call updateSourceControl and fire
onDidChangeCommitTemplateEmitter
But Theia does not provide a
onDidChangeCommitTemplate
listenersSo the
vscode-git
cann't update the SCM-inputVscode References
How to test
example/browser
dependencies@theia/git
[email protected]
totheiaPlugins
Note the SCM input, should be with value
Merge branch 'conflict'