Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chevron icon with codicon #9770

Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jul 23, 2021

What it does

Closes #9744

Replaces the chevron svg with a codicon.

How to test

  1. Assert that the chevron still behaves as expected.
  2. Switch to a light theme.
  3. Observe that the chevron is colored correctly.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience labels Jul 23, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍
I confirmed that it works for multiple trees (explorer, file-dialog, siw, problems).

@msujew msujew force-pushed the msujew/tree-chevron-codicon branch from b1631dc to 54e956b Compare July 24, 2021 13:38
@vince-fugnitto vince-fugnitto merged commit e1c2369 into eclipse-theia:master Jul 29, 2021
@vince-fugnitto vince-fugnitto added this to the 1.16.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree: adjust expansion toggle when node is selected
2 participants