Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monaco: fix monaco peek styling #9725

Merged
merged 1 commit into from
Jul 15, 2021
Merged

monaco: fix monaco peek styling #9725

merged 1 commit into from
Jul 15, 2021

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #9458.

The pull-request updates the monaco peekview-widget fontFamily styling.
The title and references are now aligned with the styling of vscode.

peek-styling

How to test

  1. start the application with theia as a workspace folder
  2. open a typescript file (wait for language-server to initialize)
  3. use the context-menu item - peek > peek type definition
  4. the styling for the filename, and result (tree or flat list) should be displayed correctly

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto
monaco: fix monaco peek styling
c2bd2b7 
The commit updates the monaco peekview-widget `fontFamily` styling.
The title and references are now aligned with the styling of vscode.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Jul 13, 2021
msujew
msujew approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the peek display now uses the same font as the rest of the application.

image

colin-grant-work
colin-grant-work approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable and the bug is indeed fixed.

@vince-fugnitto vince-fugnitto merged commit 3181ed3 into master Jul 15, 2021
@vince-fugnitto vince-fugnitto deleted the vf/peekview-widget branch July 15, 2021 15:21
@vince-fugnitto vince-fugnitto added this to the 1.16.0 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
monaco issues related to monaco ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

monaco: fix peek fontFamily styling
3 participants
@vince-fugnitto @msujew @colin-grant-work