Don't modify settings.json when adding debug configurations #9719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9712 by checking whether the file found is a default config file (
settings.json
) before modifying it when adding debug configurations.How to test
.theia
folder and populate it with asettings.json
that includes a `"launch" field. Something like this:settings.json
and put you in the middle of the array, but it should not remove your "editor.fontSize" setting.Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant [email protected]