Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify settings.json when adding debug configurations #9719

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #9712 by checking whether the file found is a default config file (settings.json) before modifying it when adding debug configurations.

How to test

  1. In an otherwise empty folder, create a .theia folder and populate it with a settings.json that includes a `"launch" field. Something like this:
{
  "launch": {
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    "version": "0.2.0",
    "configurations": []
  },
  "editor.fontSize": 20
}
  1. Open that folder in Theia.
  2. Open the debug view, open the dropdown and select 'Add configurations'
  3. It should open your settings.json and put you in the middle of the array, but it should not remove your "editor.fontSize" setting.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant [email protected]

@colin-grant-work colin-grant-work added bug bugs found in the application debug issues that related to debug functionality preferences issues related to preferences labels Jul 8, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it fixes the reported issue #9712 👍

@colin-grant-work colin-grant-work merged commit 2a5c157 into master Jul 9, 2021
@github-actions github-actions bot added this to the 1.16.0 milestone Jul 9, 2021
@colin-grant-work colin-grant-work deleted the bugfix/debug-in-settings-json branch July 9, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade 1.14.0 is causing problem with settings.json
2 participants