-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace: Rename files/folder is case sensitive #9709
Workspace: Rename files/folder is case sensitive #9709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes on Windows and Ubuntu. The behavior on Ubuntu didn't change, while it fixed the issue on Windows. I tried:
- Renaming a file to the same name but with a different case.
- Renaming a file to create a name collision with an existing file with the same case as the other file.
- Renaming a file to create a name collision with an existing file with a different case.
LGTM 👍
fb824ec
to
28280d1
Compare
28280d1
to
945537d
Compare
The code is OK for me but I can't approve it because I don't have a Windows workstation to test it. |
945537d
to
c85774e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested everything again, as the code changed a lot since the last time I took a look at it. However, everything still performs as expected.
c85774e
to
66a05e1
Compare
@paul-marechal Anything blocking you from approving/retesting? |
66a05e1
to
33f5fb1
Compare
This commit fixes the rename command for windows users by making possible the case sensitive rename of files and folders. Also, it adds the test file workspace-commands.spec.ts which verifies that the implementation works as expected.
33f5fb1
to
52e4d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, and I confirm that I am now able to rename files by just changing the case on Windows.
What it does
Fixes #9663
This commit fixes the rename command for windows users by making possible
the case sensitive rename of files and folders. Also, it adds the test file
workspace-commands.spec.ts
which verifies that the implementation works as expected.How to test
If your operating system is Windows, you can test this commit with the following steps in the browser or electron target :
foo
a.txt
andb.txt
a.txt
toA.txt
b.txt
toa.txt
You can also test the commit by running :
npx run build @theia/workspace && npx run test @theia/workspace
Review checklist
Reminder for reviewers