Tests: update file-search tests #9674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarSdt-EC
force-pushed
the
os/tests_file-search
branch
from
333c266 to
21c933f
Compare
vince-fugnitto
added
file search
vince-fugnitto
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
@OmarSdt-EC do you mind rebasing the pull-request against the latest master?
OmarSdt-EC
force-pushed
the
os/tests_file-search
branch
2 times, most recently
from
447eb78 to
b00b535
Compare
vince-fugnitto
approved these changes
Jul 26, 2021
OmarSdt-EC
force-pushed
the
os/tests_file-search
branch
from
b00b535 to
6170b58
Compare
The commit updates the `file-search` api-tests (integration) by testing the following: - verify `fileAndRange` property by default, and once a search is performed. - verify that `splitFilterAndRange` successfully handles different input value combinations.
OmarSdt-EC
force-pushed
the
os/tests_file-search
branch
from
6170b58 to
c58e16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit updates the
file-searchapi-tests (integration) by testing the following:fileAndRangeproperty by default, and once a search is performed.splitFilterAndRangesuccessfully handles different input value combinations.How to test
The CI should be green and the new tests should be executed.
You can also manually run the tests with
yarn testin theexamples/browserdirectory.Review checklist
Reminder for reviewers